public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "matz at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/111591] ppc64be: miscompilation with -mstrict-align / -O3
Date: Mon, 23 Oct 2023 12:36:42 +0000	[thread overview]
Message-ID: <bug-111591-4-UuVLbPTXgc@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-111591-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111591

Michael Matz <matz at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |matz at gcc dot gnu.org

--- Comment #28 from Michael Matz <matz at gcc dot gnu.org> ---
(In reply to Richard Biener from comment #27)
> (In reply to Kewen Lin from comment #26)
> > Thanks for the clarification! Is it possible to update the alias set for the
> > indirect accesses as well? since we know the address is originally taken
> > from one coalesced decl (also update its propagated ones).

That's not generally possible, the address-taking and the actual access might
be
separated by arbitrary obfuscating code:

   char *p = &x;
   char *p2 = get_some_pointer(p);
   *p2 = ...

Here p2 may, or may not, point to x.  So we'd need to be fairly conservative
here ...

> I suppose we could record a bitmap of all decls participating in any
> coalescing, check whether a MEM could possibly refer to any of them
> via the points-to API

... which the points-to API of course will be.

> and then force alias-set zero for those.

So that will work.  But I wonder if the result then won't be that essentially
all of the mem accesses will get alias set zero, at least if there was any
coalescing.  At that point we may also bite the bullet and just do away
with any TBAA alias sets in RTL at all.

> We
> could also try to do sophisticated analysis to make assigning a new
> alias-set for each coalesce group work, merging groups when there's
> indirect accesses that could alias a member of more than a single
> group.

Question is if the sophistication is worth it.

  parent reply	other threads:[~2023-10-23 12:36 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-25 11:53 [Bug target/111591] New: " malat at debian dot org
2023-09-25 11:55 ` [Bug target/111591] " malat at debian dot org
2023-09-25 11:59 ` rguenth at gcc dot gnu.org
2023-09-25 12:20 ` malat at debian dot org
2023-09-25 13:15 ` malat at debian dot org
2023-09-25 13:41 ` malat at debian dot org
2023-09-26  6:50 ` linkw at gcc dot gnu.org
2023-09-26  7:56 ` rguenth at gcc dot gnu.org
2023-09-26  8:14 ` linkw at gcc dot gnu.org
2023-09-26  9:28 ` malat at debian dot org
2023-09-26  9:28 ` malat at debian dot org
2023-09-26  9:31 ` malat at debian dot org
2023-09-26  9:31 ` malat at debian dot org
2023-09-27  9:24 ` linkw at gcc dot gnu.org
2023-09-27  9:26 ` rguenth at gcc dot gnu.org
2023-09-28  0:20 ` linkw at gcc dot gnu.org
2023-10-13 10:19 ` linkw at gcc dot gnu.org
2023-10-13 11:08 ` rguenth at gcc dot gnu.org
2023-10-13 12:09 ` linkw at gcc dot gnu.org
2023-10-13 12:32 ` rguenth at gcc dot gnu.org
2023-10-16  9:11 ` linkw at gcc dot gnu.org
2023-10-19  7:27 ` linkw at gcc dot gnu.org
2023-10-19 11:06 ` rguenth at gcc dot gnu.org
2023-10-19 11:12 ` rguenth at gcc dot gnu.org
2023-10-20  5:53 ` linkw at gcc dot gnu.org
2023-10-20  6:25 ` rguenth at gcc dot gnu.org
2023-10-23  3:21 ` linkw at gcc dot gnu.org
2023-10-23  9:48 ` rguenth at gcc dot gnu.org
2023-10-23 12:36 ` matz at gcc dot gnu.org [this message]
2023-10-23 13:30 ` rguenth at gcc dot gnu.org
2023-10-23 14:04 ` rguenth at gcc dot gnu.org
2023-10-24  2:59 ` linkw at gcc dot gnu.org
2023-10-31  6:40 ` linkw at gcc dot gnu.org
2023-12-13  8:00 ` cvs-commit at gcc dot gnu.org
2023-12-13  8:02 ` rguenth at gcc dot gnu.org
2023-12-13  8:12 ` rguenth at gcc dot gnu.org
2023-12-15  7:32 ` malat at debian dot org
2023-12-15  7:43 ` rguenth at gcc dot gnu.org
2023-12-15 10:01 ` linkw at gcc dot gnu.org
2023-12-15 10:23 ` rguenth at gcc dot gnu.org
2023-12-15 11:28 ` malat at debian dot org
2023-12-15 11:32 ` rguenth at gcc dot gnu.org
2023-12-18  6:01 ` linkw at gcc dot gnu.org
2023-12-18  6:03 ` linkw at gcc dot gnu.org
2023-12-19  5:38 ` linkw at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-111591-4-UuVLbPTXgc@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).