public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "mpolacek at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug c++/111607] False positive -Wdangling-reference Date: Thu, 18 Jan 2024 22:02:43 +0000 [thread overview] Message-ID: <bug-111607-4-BfkAld0tdW@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-111607-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111607 Marek Polacek <mpolacek at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|unassigned at gcc dot gnu.org |mpolacek at gcc dot gnu.org See Also| |https://gcc.gnu.org/bugzill | |a/show_bug.cgi?id=113256 Last reconfirmed| |2024-01-18 Ever confirmed|0 |1 Status|UNCONFIRMED |ASSIGNED --- Comment #1 from Marek Polacek <mpolacek at gcc dot gnu.org> --- Thanks for the report. I suppose we should not warn when the argument is a lambda type. This might also fix bug 113256. --- a/gcc/cp/call.cc +++ b/gcc/cp/call.cc @@ -14123,7 +14123,8 @@ do_warn_dangling_reference (tree expr, bool arg_p) tree e = expr; while (handled_component_p (e)) e = TREE_OPERAND (e, 0); - if (!reference_like_class_p (TREE_TYPE (e))) + if (!reference_like_class_p (TREE_TYPE (e)) + && !LAMBDA_TYPE_P (TREE_TYPE (e))) return expr; } @@ -14180,10 +14181,10 @@ do_warn_dangling_reference (tree expr, bool arg_p) initializing this reference parameter. */ if (do_warn_dangling_reference (arg, /*arg_p=*/true)) return expr; - /* Don't warn about member function like: + /* Don't warn about member functions like: std::any a(...); S& s = a.emplace<S>({0}, 0); - which constructs a new object and returns a reference to it, but + which construct a new object and return a reference to it, but we still want to detect: struct S { const S& self () { return *this; } }; const S& s = S().self();
next prev parent reply other threads:[~2024-01-18 22:02 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-09-27 7:32 [Bug c++/111607] New: " fiesh at zefix dot tv 2024-01-18 22:02 ` mpolacek at gcc dot gnu.org [this message] 2024-01-23 21:36 ` [Bug c++/111607] " cvs-commit at gcc dot gnu.org 2024-01-23 22:18 ` mpolacek at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-111607-4-BfkAld0tdW@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).