public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "prathamesh3492 at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/111648] [14 Regression] Wrong code at -O2/3 on x86_64-linux-gnu since r14-3243-ga7dba4a1c05 Date: Tue, 03 Oct 2023 12:21:41 +0000 [thread overview] Message-ID: <bug-111648-4-gflWfMXVw1@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-111648-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111648 --- Comment #4 from prathamesh3492 at gcc dot gnu.org --- (In reply to prathamesh3492 from comment #3) > Created attachment 56037 [details] > Untested fix > > The issue is that when a1 is a multiple of vector length, we end up creating > following encoding in result: { base_elem, arg[0], arg[1], ... } where arg > is chosen input vector, which is incorrect. > > For above case, vectorizer pass creates VEC_PERM_EXPR<arg0, arg, sel> where: > arg0: { -16, -9, -10, -11 } > arg1: { -12, -5, -6, -7 } > sel = { 3, 4, 5, 6 } > > arg0, arg1 and sel are encoded with npatterns = 1 and nelts_per_pattern = 3. > Since a1 = 4 and arg_len = 4, it ended up creating the result with > following encoding: > res = { arg0[3], arg1[0], arg1[1] } // npatterns = 1, nelts_per_pattern = 3 > = { -11, -12, -5 } > > So for res[4], it used S = (-5) - (-12) = 7 Typo: I meant res[3], not res[4]. Sorry. > And hence computed it as -5 + 7 = 2. > instead of arg1[2], ie, -6. > which is the difference we see in output at -O0 vs -O2. > > The patch tweaks the constratints in valid_mask_for_fold_vec_perm_cst_p to > punt if a1 is a multiple of vector length, so a1 ... ae only selects from > stepped part of the input vector, which seems to fix this issue. > I will run a proper bootstrap+test and post it upstream.
next prev parent reply other threads:[~2023-10-03 12:21 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-09-30 14:04 [Bug tree-optimization/111648] New: " shaohua.li at inf dot ethz.ch 2023-09-30 16:48 ` [Bug tree-optimization/111648] " prathamesh3492 at gcc dot gnu.org 2023-10-01 18:49 ` [Bug tree-optimization/111648] [14 Regression] " pinskia at gcc dot gnu.org 2023-10-03 12:19 ` prathamesh3492 at gcc dot gnu.org 2023-10-03 12:21 ` prathamesh3492 at gcc dot gnu.org [this message] 2023-10-04 9:25 ` rguenth at gcc dot gnu.org 2023-10-18 19:04 ` cvs-commit at gcc dot gnu.org 2023-10-18 19:06 ` prathamesh3492 at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-111648-4-gflWfMXVw1@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).