public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "ubizjak at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/111657] Memory copy with structure assignment from named address space should be improved
Date: Mon, 02 Oct 2023 09:21:55 +0000	[thread overview]
Message-ID: <bug-111657-4-4oirENbAq2@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-111657-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111657

Uroš Bizjak <ubizjak at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |ubizjak at gmail dot com
             Status|NEW                         |ASSIGNED

--- Comment #4 from Uroš Bizjak <ubizjak at gmail dot com> ---
Created attachment 56030
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=56030&action=edit
Propsed patch

Proposed patch declares libcall algorithm unavailable to non-default address
spaces and falls back to a loop if everything else fails. The following
testcase:

--cut here--
struct a { long arr[30]; };

__thread struct a t;
void foo (struct a *dst) { *dst = t; }

__seg_gs struct a s;
void bar (struct a *dst) { *dst = s; }
--cut here--

now compiles (-O2 -mno-sse) to:

foo:
        movq    %fs:0, %rdx
        movl    $30, %ecx
        leaq    t@tpoff(%rdx), %rsi
        rep movsq
        ret

bar:
        xorl    %eax, %eax
.L4:
        movl    %eax, %edx
        addl    $8, %eax
        movq    %gs:s(%rdx), %rcx
        movq    %rcx, (%rdi,%rdx)
        cmpl    $240, %eax
        jb      .L4
        ret

(rep movsq copies only from the default ds: address space)

  parent reply	other threads:[~2023-10-02  9:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-01 21:41 [Bug middle-end/111657] New: Memory copy with structure assignment from named address space is not working ubizjak at gmail dot com
2023-10-01 21:57 ` [Bug middle-end/111657] " ubizjak at gmail dot com
2023-10-01 22:26 ` pinskia at gcc dot gnu.org
2023-10-01 22:31 ` [Bug target/111657] Memory copy with structure assignment from named address space should be improved pinskia at gcc dot gnu.org
2023-10-02  9:21 ` ubizjak at gmail dot com [this message]
2023-10-02  9:25 ` ubizjak at gmail dot com
2023-10-05 15:43 ` cvs-commit at gcc dot gnu.org
2023-10-05 15:46 ` ubizjak at gmail dot com
2023-11-17 12:07 ` jakub at gcc dot gnu.org
2023-11-17 13:39 ` ubizjak at gmail dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-111657-4-4oirENbAq2@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).