From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 220583858426; Wed, 11 Oct 2023 12:27:16 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 220583858426
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1697027236;
	bh=WBU4KV6ApBRfn/1Nftilwn3XpC4YoBilXiTCEyhzdqM=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=nVWhLeqcqty8Eyax2BSuStDuIBxwTRR9IcDf1/eID+c9STdpznY5P8v4hHfhnPCiY
	 0qLXN/huNw1aDViZwUI5YiaJtgEZmkD6hTBXRiwoRuTThfmbuKamAfpqR3MllQcb3T
	 XWt7OQCuDlwB9+2TObBQpLYfJAbuaEukqqhxy2MQ=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug modula2/111675] Incorrect parameter value passed when
 attempting to pass a field of a packed record as a parameter
Date: Wed, 11 Oct 2023 12:27:15 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: modula2
X-Bugzilla-Version: 14.0
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: gaius at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-111675-4-AokduaJ1WV@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-111675-4@http.gcc.gnu.org/bugzilla/>
References: <bug-111675-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D111675

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Gaius Mulley <gaius@gcc.gnu.org>:

https://gcc.gnu.org/g:2b783fe2e8103d97db7c5d6c1514ba16091f39f6

commit r14-4556-g2b783fe2e8103d97db7c5d6c1514ba16091f39f6
Author: Gaius Mulley <gaiusmod2@gmail.com>
Date:   Wed Oct 11 13:26:47 2023 +0100

    PR modula2/111675 Incorrect packed record field value passed to a proce=
dure

    This patch allows a packed field to be extracted and passed to a
    procedure.  It ensures that the subrange type is the same for both the
    procedure and record field.  It also extends the <* bytealignment (0) *>
    to cover packed subrange types.

    gcc/m2/ChangeLog:

            PR modula2/111675
            * gm2-compiler/M2CaseList.mod (appendTree): Replace
            InitStringCharStar with InitString.
            * gm2-compiler/M2GCCDeclare.mod: Import AreConstantsEqual.
            (DeclareSubrange): Add zero alignment test and call
            BuildSmallestTypeRange if necessary.
            (WalkSubrangeDependants): Walk the align expression.
            (IsSubrangeDependants): Test the align expression.
            * gm2-compiler/M2Quads.mod (BuildStringAdrParam): Correct end n=
ame.
            * gm2-compiler/P2SymBuild.mod (BuildTypeAlignment): Allow subra=
nges
            to be zero aligned (packed).
            * gm2-compiler/SymbolTable.mod (Subrange): Add Align field.
            (MakeSubrange): Set Align to NulSym.
            (PutAlignment): Assign Subrange.Align to align.
            (GetAlignment): Return Subrange.Align.
            * gm2-gcc/m2expr.cc (noBitsRequired): Rewrite.
            (calcNbits): Rename ...
            (m2expr_calcNbits): ... to this and test for negative values.
            (m2expr_BuildTBitSize): Replace calcNBits with m2expr_calcNbits.
            * gm2-gcc/m2expr.def (calcNbits): Export.
            * gm2-gcc/m2expr.h (m2expr_calcNbits): New prototype.
            * gm2-gcc/m2type.cc (noBitsRequired): Remove.
            (m2type_BuildSmallestTypeRange): Call m2expr_calcNbits.
            (m2type_BuildSubrangeType): Create range_type from
            build_range_type (type, lowval, highval).

    gcc/testsuite/ChangeLog:

            PR modula2/111675
            * gm2/extensions/run/pass/packedrecord3.mod: New test.

    Signed-off-by: Gaius Mulley <gaiusmod2@gmail.com>=