public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "amacleod at redhat dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/111694] [13/14 Regression] Wrong behavior for signbit of negative zero when optimizing
Date: Fri, 06 Oct 2023 17:30:03 +0000	[thread overview]
Message-ID: <bug-111694-4-CXx2VXBtJZ@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-111694-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111694

--- Comment #4 from Andrew Macleod <amacleod at redhat dot com> ---
(In reply to Richard Biener from comment #3)
> Looks like some frange / relation mistake then.


l_3(D)  [frange] double [-Inf, +Inf]
Equivalence set : [l_3(D), r_4(D)]
    <bb 3> :
    _1 = __builtin_signbit (l_3(D));
    if (_1 != 0)
      goto <bb 6>; [INV]
    else
      goto <bb 4>; [INV]

3->6  (T) _1 :  [irange] int [-INF, -1][1, +INF]
3->6  (T) l_3(D) :      [frange] double [-Inf, -0.0 (-0x0.0p+0)]
3->4  (F) _1 :  [irange] int [0, 0]
3->4  (F) l_3(D) :      [frange] double [0.0 (0x0.0p+0), +Inf]

    <bb 4> :
    _2 = __builtin_signbit (r_4(D));

Yeah, we know l_3 and r_4 are equivalent, and we also know that on the edge
3->4 l_3 has the range  double [0.0 (0x0.0p+0), +Inf]

When we miss is that with an equivalence, we also have to put -0.0 back into
the range.  We currently don't so we think we can fold the second signbit call.

If I fix that, we then see 
r_4(D)  [frange] double [-0.0 (-0x0.0p+0), +Inf]
which prevents the folding.  

I need to audit to see if there are other places where we may have to "adjust"
equivalence range, or how best to deal with this in the general case.

  parent reply	other threads:[~2023-10-06 17:30 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-04 17:09 [Bug web/111694] New: " alonzakai at gmail dot com
2023-10-04 18:31 ` [Bug tree-optimization/111694] [13/14 Regression] " amonakov at gcc dot gnu.org
2023-10-04 19:09 ` pinskia at gcc dot gnu.org
2023-10-05  7:37 ` rguenth at gcc dot gnu.org
2023-10-06 17:30 ` amacleod at redhat dot com [this message]
2023-10-09 17:10 ` cvs-commit at gcc dot gnu.org
2023-10-09 17:11 ` amacleod at redhat dot com
2023-10-09 17:18 ` amonakov at gcc dot gnu.org
2023-10-09 17:36 ` amacleod at redhat dot com
2023-10-09 19:37 ` amacleod at redhat dot com
2023-10-11 20:45 ` cvs-commit at gcc dot gnu.org
2023-10-11 20:48 ` amacleod at redhat dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-111694-4-CXx2VXBtJZ@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).