public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/111697] Sub optimal code gen for initialising vector using loop
Date: Thu, 05 Oct 2023 07:48:10 +0000 [thread overview]
Message-ID: <bug-111697-4-AmR7h8B1Vf@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-111697-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111697
--- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> ---
(In reply to Richard Biener from comment #2)
> We have quite some code doing vector CTOR stuff in tree-ssa-forwprop.cc and
> this should be optimized to
>
> v_2 = { x_6(D), x_6(D), x_6(D), x_6(D) };
>
> note SLP vectorization can do this but it fails because it doesn't handle
> a default def insert - it handles a group of BIT_INSERT_EXPRs as
> vector CTOR and SLP discovery doesn't know how to start from external defs
> (it needs actual definition stmts).
>
> A more general approach would be to try to track vector construction through
> symbolic execution like we form bswap in the bswap pass.
You could "steal" the code in vect_slp_check_for_roots,
else if (code == BIT_INSERT_EXPR
&& VECTOR_TYPE_P (TREE_TYPE (rhs))
&& TYPE_VECTOR_SUBPARTS (TREE_TYPE (rhs)).is_constant ()
&& TYPE_VECTOR_SUBPARTS (TREE_TYPE (rhs)).to_constant () > 1
&& integer_zerop (gimple_assign_rhs3 (assign))
&& useless_type_conversion_p
(TREE_TYPE (TREE_TYPE (rhs)),
TREE_TYPE (gimple_assign_rhs2 (assign)))
&& bb_vinfo->lookup_def (gimple_assign_rhs2 (assign)))
{
/* We start to match on insert to lane zero but since the
inserts need not be ordered we'd have to search both
the def and the use chains. */
...
and put it into tree-ssa-forwprop.cc, explicitly creating the vector CTOR.
prev parent reply other threads:[~2023-10-05 7:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-04 19:25 [Bug tree-optimization/111697] New: " prathamesh3492 at gcc dot gnu.org
2023-10-04 19:31 ` [Bug tree-optimization/111697] " pinskia at gcc dot gnu.org
2023-10-05 7:46 ` rguenth at gcc dot gnu.org
2023-10-05 7:48 ` rguenth at gcc dot gnu.org [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-111697-4-AmR7h8B1Vf@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).