From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id DC8223849ACA; Thu,  9 May 2024 17:12:36 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DC8223849ACA
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1715274756;
	bh=ndTwDBXgd1S+DQzrbTivTxq6vjmAr8BMwaEp0rYzGxo=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=FiO3Pe/LOslmouxwC+LB1yhq6sGTNTkUQOCQqjahVRHMcjOyxG0bfSI+YGsepsdYz
	 IbdTZa7tFgUO3QBdXXaFTn/JJzCEQ18/Ns3zZboYFtiapmh9JOEFzqNAsYT0+ZTQCB
	 TSs5AhHXqZvhGsp19juAmP+mvviKRaLAvENyA/r0=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug driver/111700] ICE: SIGSEGV in needs_read_p (input.cc:598) with
 -fdiagnostics-format=sarif-file or -fdiagnostics-format=sarif-stderr on
 pre-processed input
Date: Thu, 09 May 2024 17:12:33 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: driver
X-Bugzilla-Version: 14.0
X-Bugzilla-Keywords: diagnostic, ice-on-valid-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-111700-4-hqnxYXsjGM@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-111700-4@http.gcc.gnu.org/bugzilla/>
References: <bug-111700-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D111700

--- Comment #4 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-13 branch has been updated by David Malcolm
<dmalcolm@gcc.gnu.org>:

https://gcc.gnu.org/g:230f672b3ed0f64c9110ef9dba616c17d713816d

commit r13-8759-g230f672b3ed0f64c9110ef9dba616c17d713816d
Author: David Malcolm <dmalcolm@redhat.com>
Date:   Thu May 9 13:09:32 2024 -0400

    diagnostics: fix ICE on sarif output when source file is unreadable
[PR111700]

    Backported from r14-4474-g94caa6a6b4bd73.

    gcc/ChangeLog:
            PR driver/111700
            * input.cc (file_cache::add_file): Update leading comment to
            clarify that it can fail.
            (file_cache::lookup_or_add_file): Likewise.
            (get_source_file_content): Gracefully handle lookup_or_add_file
            failing.

    gcc/testsuite/ChangeLog:
            PR driver/111700
            * c-c++-common/diagnostic-format-sarif-file-pr111700.c: New tes=
t.

    Signed-off-by: David Malcolm <dmalcolm@redhat.com>=