public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/111784] [14 Regression] aarch64: ldp_stp_{15,16,17,18}.c test failures since r14-4579
Date: Mon, 23 Oct 2023 02:24:32 +0000	[thread overview]
Message-ID: <bug-111784-4-WygONXCWva@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-111784-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111784

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Kewen Lin <linkw@gcc.gnu.org>:

https://gcc.gnu.org/g:1908775f7982bd2de36df5d94396eca0865bad9a

commit r14-4842-g1908775f7982bd2de36df5d94396eca0865bad9a
Author: Kewen Lin <linkw@linux.ibm.com>
Date:   Sun Oct 22 21:18:40 2023 -0500

    vect: Cost adjacent vector loads/stores together [PR111784]

    As comments[1][2], this patch is to change the costing way
    on some adjacent vector loads/stores from costing one by
    one to costing them together with the total number once.

    It helps to fix the exposed regression PR111784 on aarch64,
    as aarch64 specific costing could make different decisions
    according to the different costing ways (counting with total
    number vs. counting one by one).  Based on a reduced test
    case from PR111784, only considering vec_num can fix the
    regression already, but vector loads/stores in regard to
    ncopies are also adjacent accesses, so they are considered
    as well.

    btw, this patch leaves the costing on dr_explicit_realign
    and dr_explicit_realign_optimized alone to make it simple.
    The costing way change can cause the differences for them
    since there is one costing depending on targetm.vectorize.
    builtin_mask_for_load and it's costed according to the
    calling times.  IIUC, these two dr_alignment_support are
    mainly used for old Power? (only having 16 bytes aligned
    vector load/store but no unaligned vector load/store).

    [1] https://gcc.gnu.org/pipermail/gcc-patches/2023-September/630742.html
    [2] https://gcc.gnu.org/pipermail/gcc-patches/2023-September/630744.html

            PR tree-optimization/111784

    gcc/ChangeLog:

            * tree-vect-stmts.cc (vectorizable_store): Adjust costing way for
            adjacent vector stores, by costing them with the total number
            rather than costing them one by one.
            (vectorizable_load): Adjust costing way for adjacent vector
            loads, by costing them with the total number rather than costing
            them one by one.

  parent reply	other threads:[~2023-10-23  2:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-12 13:02 [Bug target/111784] New: [14 Regression] aarch64: ldp_stp_{15,16,17,18}.c test failures acoplan at gcc dot gnu.org
2023-10-12 15:30 ` [Bug target/111784] " acoplan at gcc dot gnu.org
2023-10-13  0:52 ` [Bug target/111784] [14 Regression] aarch64: ldp_stp_{15,16,17,18}.c test failures since r14-4579 linkw at gcc dot gnu.org
2023-10-13  6:48 ` rguenth at gcc dot gnu.org
2023-10-23  2:24 ` cvs-commit at gcc dot gnu.org [this message]
2023-10-23  6:16 ` linkw at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-111784-4-WygONXCWva@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).