public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "pinskia at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug c/111811] [14 Regression] ICE with vector float bitfield after error Date: Sun, 12 Nov 2023 22:13:06 +0000 [thread overview] Message-ID: <bug-111811-4-WSWOsRCZgV@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-111811-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111811 Andrew Pinski <pinskia at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |accepts-invalid --- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> --- But we should also be rejecting: ``` struct A { __attribute__((__vector_size__(4))) int d : 1; }; struct A b = {0}; ``` Which we currently accepts before and ICE now. Note for the float case, we could in theory change: ``` /* Detect invalid bit-field type. */ if (TREE_CODE (*type) != INTEGER_TYPE && TREE_CODE (*type) != BOOLEAN_TYPE && TREE_CODE (*type) != ENUMERAL_TYPE && TREE_CODE (*type) != BITINT_TYPE) { error_at (loc, "bit-field %qs has invalid type", name); *type = unsigned_type_node; } ``` to use error_mark_node instead of unsigned_type_node here and that would fix the ICE for the original testcase but not the above testcase.
next prev parent reply other threads:[~2023-11-12 22:13 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-10-14 17:09 [Bug c/111811] New: gcc: internal compiler error: tree check: expected none of vector_type, have vector_type in finish_struct congli at smail dot nju.edu.cn 2023-11-12 22:09 ` [Bug c/111811] [14 Regression] ICE with vector float bitfield after error pinskia at gcc dot gnu.org 2023-11-12 22:13 ` pinskia at gcc dot gnu.org [this message] 2023-11-13 9:57 ` rguenth at gcc dot gnu.org 2023-11-13 23:24 ` joseph at codesourcery dot com 2023-11-14 8:07 ` rguenther at suse dot de 2024-01-15 13:54 ` rguenth at gcc dot gnu.org 2024-05-07 7:42 ` [Bug c/111811] [14/15 " rguenth at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-111811-4-WSWOsRCZgV@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).