public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug target/111822] [12/13/14 Regression] during RTL pass: lr_shrinkage ICE: in operator[], at vec.h:910 with -O2 -m32 -flive-range-shrinkage -fno-dce -fnon-call-exceptions since r12-5301-g045206450386bc Date: Fri, 08 Mar 2024 13:02:53 +0000 [thread overview] Message-ID: <bug-111822-4-YzvxYmBejv@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-111822-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111822 --- Comment #12 from Richard Biener <rguenth at gcc dot gnu.org> --- (In reply to Uroš Bizjak from comment #11) > (In reply to Richard Biener from comment #10) > > The easiest fix would be to refuse applying STV to a insn that > > can_throw_internal () (that's an insn that has associated EH info). Updating > > in this case would require splitting the BB or at least moving the now > > no longer throwing insn to the next block (along the fallthru edge). > > This would be simply: > > --cut here-- > diff --git a/gcc/config/i386/i386-features.cc > b/gcc/config/i386/i386-features.cc > index 1de2a07ed75..90acb33db49 100644 > --- a/gcc/config/i386/i386-features.cc > +++ b/gcc/config/i386/i386-features.cc > @@ -437,6 +437,10 @@ scalar_chain::add_insn (bitmap candidates, unsigned int > insn_uid, > && !HARD_REGISTER_P (SET_DEST (def_set))) > bitmap_set_bit (defs, REGNO (SET_DEST (def_set))); > > + if (cfun->can_throw_non_call_exceptions that part shouldn't be necessary, can_throw_internal is cheap enough (but yes, unless STV handles calls it's correct) > + && can_throw_internal (insn)) > + return false; > + > /* ??? The following is quadratic since analyze_register_chain > iterates over all refs to look for dual-mode regs. Instead this > should be done separately for all regs mentioned in the chain once. */ > --cut here-- > > But I think, we could do better. Adding CC. We sure could, but I doubt it's too important? Maybe for Go/Ada.
next prev parent reply other threads:[~2024-03-08 13:02 UTC|newest] Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-10-15 6:14 [Bug rtl-optimization/111822] New: [12/13/14 Regression] during RTL pass: lr_shrinkage ICE: in operator[], at vec.h:910 with -O2 -m32 -flive-range-shrinkage -fno-dce -fnon-call-exceptions zsojka at seznam dot cz 2023-10-16 7:22 ` [Bug rtl-optimization/111822] " rguenth at gcc dot gnu.org 2023-10-22 23:50 ` pinskia at gcc dot gnu.org 2023-10-23 20:48 ` sjames at gcc dot gnu.org 2023-10-23 22:36 ` [Bug rtl-optimization/111822] [12/13/14 Regression] during RTL pass: lr_shrinkage ICE: in operator[], at vec.h:910 with -O2 -m32 -flive-range-shrinkage -fno-dce -fnon-call-exceptions since r12-5301-g045206450386bc sjames at gcc dot gnu.org 2024-03-07 21:04 ` law at gcc dot gnu.org 2024-03-08 7:01 ` rguenth at gcc dot gnu.org 2024-03-08 7:13 ` zsojka at seznam dot cz 2024-03-08 7:50 ` rguenth at gcc dot gnu.org 2024-03-08 7:50 ` rguenth at gcc dot gnu.org 2024-03-08 8:13 ` [Bug target/111822] " rguenth at gcc dot gnu.org 2024-03-08 9:58 ` ubizjak at gmail dot com 2024-03-08 10:20 ` rguenth at gcc dot gnu.org 2024-03-08 12:59 ` ubizjak at gmail dot com 2024-03-08 13:02 ` rguenth at gcc dot gnu.org [this message] 2024-03-08 13:22 ` ubizjak at gmail dot com 2024-03-08 13:28 ` rguenth at gcc dot gnu.org 2024-03-10 10:33 ` ebotcazou at gcc dot gnu.org 2024-03-11 1:27 ` liuhongt at gcc dot gnu.org 2024-03-14 8:09 ` liuhongt at gcc dot gnu.org 2024-03-18 16:27 ` ubizjak at gmail dot com 2024-03-18 19:41 ` cvs-commit at gcc dot gnu.org 2024-03-19 15:57 ` cvs-commit at gcc dot gnu.org 2024-03-19 16:00 ` cvs-commit at gcc dot gnu.org 2024-03-19 16:01 ` ubizjak at gmail dot com
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-111822-4-YzvxYmBejv@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).