From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 545E33857BA8; Mon, 27 Nov 2023 08:23:32 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 545E33857BA8
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1701073412;
	bh=pmxPbv0MIX1cAaaWfvM08bjV9pm+vSH9aa523AqblVY=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=otHHf8yKe0SxjJYvF2sTZcS0jxMiiNQ5aWNxckqgVvJZWmr6BZ9nKGD6Oc0vL8ubK
	 YVhY4QdYy/w3qno6JIo587y+LFgjGnyMePjOmrHsQ4AaL0rHErCfbiCj7gvwjvnIW6
	 MphXhZEHch6GXTEKxuR6FJT8a3PKBNSykwCSVro8=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/112300] [14 Regression] Cross compiling to
 mipsisa64r2-sde-elf fails because "HEAP_TRAMPOLINES_INIT was not declared in
 this scope" since r14-4821-g28d8c680aaea46
Date: Mon, 27 Nov 2023 08:23:25 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 14.0
X-Bugzilla-Keywords: build
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P1
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 14.0
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-112300-4-5GsViCoadB@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-112300-4@http.gcc.gnu.org/bugzilla/>
References: <bug-112300-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D112300

--- Comment #2 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:221166ad15eb37b047c77118f2eb1c8442eaa27b

commit r14-5868-g221166ad15eb37b047c77118f2eb1c8442eaa27b
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Mon Nov 27 09:22:20 2023 +0100

    mips: Fix up mips*-sde-elf* build [PR112300]

    As reported in the PR, mipsisa64r2-sde-elf doesn't build because
HEAP_TRAMPOLINES_INIT
    macro isn't defined anywhere.
    It is normally defined by
     # Figure out if we need to enable heap trampolines by default
     case ${target} in
     *-*-darwin2*)
       # Currently, we do this for macOS 11 and above.
       tm_defines=3D"$tm_defines HEAP_TRAMPOLINES_INIT=3D1"
       ;;
     *)
       tm_defines=3D"$tm_defines HEAP_TRAMPOLINES_INIT=3D0"
       ;;
     esac
    in config.gcc, but mips*-sde-elf* is the only target which overwrites
    tm_defines shell variable rather than just appending to it (or in one c=
ase
    prepending), all other targets append something to it, including other
    mips* triplets.
    I believe (just from looking at config.gcc) that the difference is that
    LIBC_GLIBC=3D1 LIBC_UCLIBC=3D2 LIBC_BIONIC=3D3 LIBC_MUSL=3D4
HEAP_TRAMPOLINES_INIT=3D0
    isn't defined without the patch and is with the patch.

    I think defining those first 4 shouldn't cause any harm and defining the
    last one is required for it to actually build at all.

    2023-11-27  Jakub Jelinek  <jakub@redhat.com>

            PR target/112300
            * config.gcc (mips*-sde-elf*): Append to tm_defines rather than
            overwriting them.=