public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug c++/112301] [12/13/14 regression] Double destruction of returned object when exiting the scope causes an exception which gets rethrown since r12-6333-gb10e031458d541 Date: Fri, 17 Nov 2023 00:21:38 +0000 [thread overview] Message-ID: <bug-112301-4-CUZ6iSRlXZ@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-112301-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112301 --- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The releases/gcc-13 branch has been updated by Jason Merrill <jason@gcc.gnu.org>: https://gcc.gnu.org/g:d237e7b291ff52095d600e6489a54b4ba8aaf608 commit r13-8079-gd237e7b291ff52095d600e6489a54b4ba8aaf608 Author: Jason Merrill <jason@redhat.com> Date: Mon Oct 30 17:44:54 2023 -0400 c++: retval dtor on rethrow [PR112301] In r12-6333 for PR33799, I fixed the example in [except.ctor]/2. In that testcase, the exception is caught and the function returns again, successfully. In this testcase, however, the exception is rethrown, and hits two separate cleanups: one in the try block and the other in the function body. So we destroy twice an object that was only constructed once. Fortunately, the fix for the normal case is easy: we just need to clear the "return value constructed by return" flag when we do it the first time. This gets more complicated with the named return value optimization, since we don't want to destroy the return value while the NRV variable is still in scope. PR c++/112301 PR c++/102191 PR c++/33799 gcc/cp/ChangeLog: * except.cc (maybe_splice_retval_cleanup): Clear current_retval_sentinel when destroying retval. * semantics.cc (nrv_data): Add in_nrv_cleanup. (finalize_nrv): Set it. (finalize_nrv_r): Fix handling of throwing cleanups. gcc/testsuite/ChangeLog: * g++.dg/eh/return1.C: Add more cases.
next prev parent reply other threads:[~2023-11-17 0:21 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-10-30 16:14 [Bug c++/112301] New: Double destruction of returned object when exiting the scope causes an exception which gets rethrown alexander.grund@tu-dresden.de 2023-10-30 16:29 ` [Bug c++/112301] [Regression 12/13/14] " redi at gcc dot gnu.org 2023-10-30 21:45 ` jason at gcc dot gnu.org 2023-11-02 20:01 ` [Bug c++/112301] [12/13/14 regression] Double destruction of returned object when exiting the scope causes an exception which gets rethrown since r12-6333-gb10e031458d541 cvs-commit at gcc dot gnu.org 2023-11-02 20:03 ` jason at gcc dot gnu.org 2023-11-03 10:01 ` alexander.grund@tu-dresden.de 2023-11-17 0:21 ` cvs-commit at gcc dot gnu.org 2023-11-17 0:21 ` cvs-commit at gcc dot gnu.org [this message] 2024-01-12 8:27 ` rguenth at gcc dot gnu.org 2024-01-12 8:32 ` pinskia at gcc dot gnu.org 2024-03-04 4:26 ` law at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-112301-4-CUZ6iSRlXZ@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).