public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "pinskia at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/112324] phiopt fail to recog if (b < 0) max = MAX(-b, max); else max = MAX (b, max) into max = MAX (ABS(b), max)
Date: Mon, 06 Nov 2023 20:23:17 +0000	[thread overview]
Message-ID: <bug-112324-4-ZTVPWcJmjU@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-112324-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112324

--- Comment #5 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
(In reply to Andrew Pinski from comment #4)
> (In reply to Andrew Pinski from comment #3)
> > Note a simple patch to improve phiopt here does not improve the original
> > code in openjpeg.
> > 
> > The reason why is due to the code in phiopt here is only operates on the
> > case where the phi would be the only one. In that case we also have a vop
> > phi which changes which causes the code not to be done.
> 
> But maybe ifcvt could use the same function to do the transformation before
> it does the conversion ...

I will try to figure that out next but I want to get this patch though.

  parent reply	other threads:[~2023-11-06 20:23 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-01  1:26 [Bug middle-end/112324] New: " crazylht at gmail dot com
2023-11-01  1:32 ` [Bug tree-optimization/112324] " pinskia at gcc dot gnu.org
2023-11-01  1:33 ` pinskia at gcc dot gnu.org
2023-11-06 17:27 ` pinskia at gcc dot gnu.org
2023-11-06 17:56 ` pinskia at gcc dot gnu.org
2023-11-06 20:23 ` pinskia at gcc dot gnu.org [this message]
2023-11-19 16:23 ` sjames at gcc dot gnu.org
2023-11-19 16:43 ` pinskia at gcc dot gnu.org
2023-11-19 17:13 ` pinskia at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-112324-4-ZTVPWcJmjU@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).