public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/112327] RVV: Redundant vmv1r for widen reduction
Date: Thu, 02 Nov 2023 00:51:34 +0000	[thread overview]
Message-ID: <bug-112327-4-qrnsVLKGqZ@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-112327-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112327

--- Comment #1 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Pan Li <panli@gcc.gnu.org>:

https://gcc.gnu.org/g:1a0af6e5a99cd895a663f0221c25321ae802413f

commit r14-5067-g1a0af6e5a99cd895a663f0221c25321ae802413f
Author: Juzhe-Zhong <juzhe.zhong@rivai.ai>
Date:   Wed Nov 1 14:56:39 2023 +0800

    RISC-V: Allow dest operand and accumulator operand overlap of widen
reduction instruction[PR112327]

    Consider this following intrinsic code:

    void rvv_dot_prod(int16_t *pSrcA, int16_t *pSrcB, uint32_t n, int64_t
*result)
    {
        size_t vl;
        vint16m4_t vSrcA, vSrcB;
        vint64m1_t vSum = __riscv_vmv_s_x_i64m1(0, 1);
        while (n > 0) {
            vl = __riscv_vsetvl_e16m4(n);
            vSrcA = __riscv_vle16_v_i16m4(pSrcA, vl);
            vSrcB = __riscv_vle16_v_i16m4(pSrcB, vl);
            vSum =
__riscv_vwredsum_vs_i32m8_i64m1(__riscv_vwmul_vv_i32m8(vSrcA, vSrcB, vl), vSum,
vl);
            pSrcA += vl;
            pSrcB += vl;
            n -= vl;
        }
        *result = __riscv_vmv_x_s_i64m1_i64(vSum);
    }

    https://godbolt.org/z/vWd35W7G6

    Before this patch:

    ...
    Loop:
    ...
    vmv1r.v v2,v1
    ...
    vwredsum.vs     v1,v8,v2
    ...

    After this patch:

    ...
    Loop:
    ...
    vwredsum.vs     v1,v8,v1
    ...

            PR target/112327

    gcc/ChangeLog:

            * config/riscv/vector.md: Add '0'.

    gcc/testsuite/ChangeLog:

            * gcc.target/riscv/rvv/base/pr112327-1.c: New test.
            * gcc.target/riscv/rvv/base/pr112327-2.c: New test.

  reply	other threads:[~2023-11-02  0:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-01  6:17 [Bug c/112327] New: " juzhe.zhong at rivai dot ai
2023-11-02  0:51 ` cvs-commit at gcc dot gnu.org [this message]
2023-11-02  0:52 ` [Bug target/112327] " juzhe.zhong at rivai dot ai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-112327-4-qrnsVLKGqZ@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).