public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "federico at kircheis dot it" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug c++/112335] missed optimization on reset and assign unique_ptr Date: Thu, 02 Nov 2023 08:01:07 +0000 [thread overview] Message-ID: <bug-112335-4-pOWWNqFOOH@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-112335-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112335 --- Comment #5 from Federico Kircheis <federico at kircheis dot it> --- Ok, the described case would be something like ---- std::unique_ptr<s> t; __thread bool tt; inline s::~s() { if (tt) return; tt = true; t.reset(new s); tt = false; } std::unique_ptr<s> t2; bar(t, t2); ---- The postcondition of p.reset() is that p == nullptr. ---- void reset(pointer p = pointer()) noexcept; Preconditions: The expression get_deleter()(get()) is well-formed, has well-defined behavior, and does not throw exceptions. Effects: Assigns p to the stored pointer, and then if and only if the old value of the stored pointer, old_p, was not equal to nullptr, calls get_deleter()(old_p). [Note: The order of these operations is significant because the call to get_deleter() may destroy *this. — end note] Postconditions: get() == p. [Note: The postcondition does not hold if the call to get_deleter() destroys *this since this->get() is no longer a valid expression. — end note] ---- I do not think that the case you have in mind is supported by the standard, but the postcondition does not hold with some deleters, so not sure if that could be relevant here
next prev parent reply other threads:[~2023-11-02 8:01 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-11-01 13:26 [Bug c++/112335] New: " federico at kircheis dot it 2023-11-01 15:51 ` [Bug c++/112335] " pinskia at gcc dot gnu.org 2023-11-02 7:17 ` federico at kircheis dot it 2023-11-02 7:19 ` federico at kircheis dot it 2023-11-02 7:30 ` pinskia at gcc dot gnu.org 2023-11-02 8:01 ` federico at kircheis dot it [this message] 2023-11-02 17:23 ` redi at gcc dot gnu.org 2023-11-03 8:06 ` federico at kircheis dot it 2023-11-03 9:10 ` redi at gcc dot gnu.org 2023-11-03 10:23 ` federico at kircheis dot it 2023-11-03 14:23 ` redi at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-112335-4-pOWWNqFOOH@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).