public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "hewillk at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/112349] ranges::max makes unnecessary copies
Date: Sat, 04 Nov 2023 12:05:08 +0000 [thread overview]
Message-ID: <bug-112349-4-KrfsDT1mBu@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-112349-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112349
康桓瑋 <hewillk at gmail dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |hewillk at gmail dot com
--- Comment #2 from 康桓瑋 <hewillk at gmail dot com> ---
(In reply to Jonathan Wakely from comment #1)
>
> I think that would be OK too.
>
> auto __result = *__first;
> while (++__first != __last)
> {
> if (std::__invoke(__comp,
> std::__invoke(__proj, __result),
> std::__invoke(__proj, *__first)))
> __result = *__first;
> }
> return __result;
`auto __result = *__first;` may not be OK, `range_value_t<_Range>
__result(*__first);` is OK.
prev parent reply other threads:[~2023-11-04 12:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-02 13:31 [Bug c++/112349] New: ranges::max makes unecessary copies ted at lyncon dot se
2023-11-02 18:02 ` [Bug libstdc++/112349] ranges::max makes unnecessary copies redi at gcc dot gnu.org
2023-11-04 12:05 ` hewillk at gmail dot com [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-112349-4-KrfsDT1mBu@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).