public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug libstdc++/112351] New: libstdc++ locale init doesn't handle __gthread_once failure Date: Thu, 02 Nov 2023 15:07:19 +0000 [thread overview] Message-ID: <bug-112351-4@http.gcc.gnu.org/bugzilla/> (raw) https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112351 Bug ID: 112351 Summary: libstdc++ locale init doesn't handle __gthread_once failure Product: gcc Version: 13.2.1 Status: UNCONFIRMED Severity: normal Priority: P3 Component: libstdc++ Assignee: unassigned at gcc dot gnu.org Reporter: rguenth at gcc dot gnu.org Target Milestone: --- pthread_once called through gthread_once can return "an error number" but the locale init code isn't prepared for that, instead leaving the object uninitialized: src/c++98/locale.cc: __c_locale locale::facet::_S_get_c_locale() { #ifdef __GTHREADS if (__gthread_active_p()) __gthread_once(&_S_once, _S_initialize_once); else #endif { if (!_S_c_locale) _S_initialize_once(); } return _S_c_locale; } OTOH similar code exists for C++11 locales which doesn't specifically handle errors but instead executes the non-threaded fallback code in that case: src/c++11/locale_init.cc: void locale::_S_initialize() { #ifdef __GTHREADS if (!__gnu_cxx::__is_single_threaded()) __gthread_once(&_S_once, _S_initialize_once); #endif if (__builtin_expect(!_S_classic, 0)) _S_initialize_once(); } Imagine an application overriding pthread_once (and other thread functions) with an implementation that "fails" before some intitialization is done (also imagine, just for curiosity, it wouldn't signal failure but success and do nothing in that case...). It would be nice to handle the situation consistently and either do the single-threaded "fallback" or abort on failure.
next reply other threads:[~2023-11-02 15:07 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-11-02 15:07 rguenth at gcc dot gnu.org [this message] 2023-11-02 15:48 ` [Bug libstdc++/112351] " redi at gcc dot gnu.org 2023-11-06 10:00 ` rguenth at gcc dot gnu.org 2023-11-06 10:47 ` redi at gcc dot gnu.org 2023-11-07 12:55 ` cvs-commit at gcc dot gnu.org 2023-11-07 12:57 ` rguenth at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-112351-4@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).