From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 348793858D39; Fri,  3 Nov 2023 20:03:44 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 348793858D39
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1699041824;
	bh=VuHun1OpCAQR4KL8yk+7yWEOahqO+soynMTrTYePsRw=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=mwQhew1SiqXULRTf7CqOptNKLKjwtTvF270w84w1qBNF71JoM2mcveONg+n37LjSx
	 IeFsQLe3QEVvYOg6llbx4+egZV0jQXgn62RWraI+xMEDBmB/1UEAFByoxPUAdydS26
	 YykbRnCWldzVUSf7YtXTsTgEGUJkfg3zKQaVH2ec=
From: "redi at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c/112373] cppcheck: libcpp/charset.cc: 3 * obvious performance
 issue
Date: Fri, 03 Nov 2023 20:03:43 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c
X-Bugzilla-Version: 14.0
X-Bugzilla-Keywords: diagnostic
X-Bugzilla-Severity: normal
X-Bugzilla-Who: redi at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: everconfirmed bug_status cf_reconfirmed_on
Message-ID: <bug-112373-4-lR7LVL5xar@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-112373-4@http.gcc.gnu.org/bugzilla/>
References: <bug-112373-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D112373

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2023-11-03

--- Comment #1 from Jonathan Wakely <redi at gcc dot gnu.org> ---
The struct is:

struct cset_converter
{
  convert_f func;
  iconv_t cd;
  int width;
  const char* from;
  const char* to;
};

So it's not too expensive to copy, but const cset_converter& would indeed be
cheaper.=