From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 855ED3858C56; Mon, 11 Dec 2023 17:33:02 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 855ED3858C56
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1702315982;
	bh=HVQu6B2Wg50MsY1Y9B/MmQruETGJT4BOWm+8eW5aE4A=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=gW/cO5VceEfKLu/aR+ScjeyGB0UMtj5xMdGbUQof9xYAyqDDHL2YduY+GlyfgR50I
	 jycJp+GYFm0wo39gIaykx4vChtTnaSt7osF5faBnBwS0729PKb6Ab1EMAl50N83tQz
	 vSinfDIjA2o9r1wqXzh8vWDTKT4PpGeSI2C8caVI=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug rtl-optimization/112380] [14 regression] ICE when building Mesa
 (in combine, internal compiler error: in simplify_subreg) since
 r14-2526-g8911879415d6c2
Date: Mon, 11 Dec 2023 17:33:00 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: rtl-optimization
X-Bugzilla-Version: 14.0
X-Bugzilla-Keywords: ice-on-valid-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: roger at nextmovesoftware dot com
X-Bugzilla-Target-Milestone: 14.0
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-112380-4-7HqOTCKFRE@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-112380-4@http.gcc.gnu.org/bugzilla/>
References: <bug-112380-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D112380

--- Comment #13 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Roger Sayle <sayle@gcc.gnu.org>:

https://gcc.gnu.org/g:624e274ca3a4405a55662fa72d1163120df0e03d

commit r14-6424-g624e274ca3a4405a55662fa72d1163120df0e03d
Author: Roger Sayle <roger@nextmovesoftware.com>
Date:   Mon Dec 11 17:30:20 2023 +0000

    PR rtl-optimization/112380: Defend against CLOBBERs in combine.cc

    This patch addresses PR rtl-optimization/112380, an ICE-on-valid regres=
sion
    where a (clobber (const_int 0)) encounters a sanity checking gcc_assert
    (at line 7554) in simplify-rtx.cc.  These CLOBBERs are used internally
    by GCC's combine pass much like error_mark_node is used by various
    language front-ends.

    The solutions are either to handle/accept these CLOBBERs through-out
    (or in more places in) the middle-end's RTL optimizers, including funct=
ions
    in simplify-rtx.cc that are used by passes other than combine, and/or
    attempt to prevent these CLOBBERs escaping from try_combine into the
    RTX/RTL stream.  The benefit of the second approach is that it actually
    allows for better optimization: when try_combine fails to simplify an
    expression instead of substituting a CLOBBER to avoid the instruction
    pattern being recognized, noticing the CLOBBER often allows combine
    to attempt alternate simplifications/transformations looking for those
    that can be recognized.

    This first alternative is the minimal fix to address the CLOBBER
    encountered in the bugzilla PR.

    2023-12-11  Roger Sayle  <roger@nextmovesoftware.com>

    gcc/ChangeLog
            PR rtl-optimization/112380
            * combine.cc (expand_field_assignment): Check if gen_lowpart
            returned a CLOBBER, and avoid calling gen_simplify_binary with
            it if so.

    gcc/testsuite/ChangeLog
            PR rtl-optimization/112380
            * gcc.dg/pr112380.c: New test case.=