From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id AED953858407; Mon, 19 Feb 2024 20:16:25 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AED953858407
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1708373785;
	bh=RWVb6OcMa8X2N3qsoP4skHB3o253ClhgDR6o33H6MjE=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=JGs0rv9d8JRA6PVq9sKlP3MxMohsz+SvJD27O16xdk7j7ELcM1KOErE7GesfvwOUI
	 JtjKia2/RxaIiitNQrCYRPH7ee5NoQDrLuztIeFL72M+F4YDqMl3DAZo8C6PGm6WE0
	 O4xVKIog3r2zfk3ni1Atcfivw6+yXuECPP3GDh+w=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/112397] Two persistent libstdc++ test failures on
 x86_64-apple-darwin
Date: Mon, 19 Feb 2024 20:16:23 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 14.0
X-Bugzilla-Keywords: testsuite-fail
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-112397-4-ATq9G1KevT@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-112397-4@http.gcc.gnu.org/bugzilla/>
References: <bug-112397-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D112397

--- Comment #11 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Iain D Sandoe <iains@gcc.gnu.org>:

https://gcc.gnu.org/g:1609fdff16f17ead37666f6d0e801800ee3d04d2

commit r14-9073-g1609fdff16f17ead37666f6d0e801800ee3d04d2
Author: Iain Sandoe <iain@sandoe.co.uk>
Date:   Thu Feb 8 17:54:31 2024 +0000

    libstdc++, Darwin: Handle a linker warning [PR112397].

    Darwin's linker warns when we make a direct branch to code that is
    in a weak definition (citing that if a different implementation of
    the weak function is chosen by the dynamic linker this would be an
    error).

    As the analysis in the PR shows, this can happen when we have hot/
    cold partitioning and there is an error path that is primarily cold
    but makes use of epilogue code in the hot section.  In this simple
    case, we can easily deduce that the code is in fact safe; however
    that is not something we can realistically implement in the linker.

    Since the user-replaceable allocators are implemented using weak
    definitions, this is a warning that is frequently flagged up in both
    the testsuite and end-user code.

    The chosen solution here is to suppress the hot/cold partitioning for
    these cases (it is unlikely to impact performance much c.f. the
    actual allocation).

            PR target/112397

    libstdc++-v3/ChangeLog:

            * configure: Regenerate.
            * configure.ac: Detect if we are building for Darwin.
            * libsupc++/Makefile.am: If we are building for Darwin, then
            suppress hot/cold partitioning for the array allocators.
            * libsupc++/Makefile.in: Regenerated.

    Signed-off-by: Iain Sandoe <iain@sandoe.co.uk>
    Co-authored-by: Jonathan Wakely <jwakely@redhat.com>=