public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "iains at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug target/112397] Two persistent libstdc++ test failures on x86_64-apple-darwin Date: Thu, 08 Feb 2024 14:02:28 +0000 [thread overview] Message-ID: <bug-112397-4-CKjWsms2W8@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-112397-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112397 --- Comment #10 from Iain Sandoe <iains at gcc dot gnu.org> --- automake if is limited to testing a single variable, so we have to introduce an AM_CONDITIONAL to say the OS is DARWIN (we did not seem to have one already, but I could have missed something else usable). I'm testing this - if it's not too invasive (but I'll also try, at some point, to see if applying this to the whole library build makes any measurable performance change) diff --git a/libstdc++-v3/configure.ac b/libstdc++-v3/configure.ac index c68cac4f345..37396bd6ebb 100644 --- a/libstdc++-v3/configure.ac +++ b/libstdc++-v3/configure.ac @@ -109,6 +109,12 @@ ACX_LT_HOST_FLAGS AC_SUBST(enable_shared) AC_SUBST(enable_static) AM_CONDITIONAL([ENABLE_DARWIN_AT_RPATH], [test x$enable_darwin_at_rpath = xyes]) +os_is_darwin=no +case ${host_os} in + darwin*) os_is_darwin=yes ;; + *) ;; +esac +AM_CONDITIONAL([OS_IS_DARWIN], [test x${os_is_darwin} = xyes]) if test "$enable_vtable_verify" = yes; then predep_objects_CXX="${predep_objects_CXX} ${glibcxx_builddir}/../libgcc/vtv_start.o" diff --git a/libstdc++-v3/libsupc++/Makefile.am b/libstdc++-v3/libsupc++/Makefile.am index d0e1618507e..645d53cb6ab 100644 --- a/libstdc++-v3/libsupc++/Makefile.am +++ b/libstdc++-v3/libsupc++/Makefile.am @@ -132,6 +132,14 @@ atomicity_file = ${glibcxx_srcdir}/$(ATOMICITY_SRCDIR)/atomicity.h atomicity.cc: ${atomicity_file} $(LN_S) ${atomicity_file} ./atomicity.cc || true +if OS_IS_DARWIN +# See PR 112397 +new_opvnt.lo: new_opvnt.cc + $(LTCXXCOMPILE) -fno-reorder-blocks-and-partition -I. -c $< +new_opvnt.o: new_opvnt.cc + $(CXXCOMPILE) -fno-reorder-blocks-and-partition -I. -c $< +endif + # AM_CXXFLAGS needs to be in each subdirectory so that it can be # modified in a per-library or per-sub-library way. Need to manually # set this option because CONFIG_CXXFLAGS has to be after
next prev parent reply other threads:[~2024-02-08 14:02 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-11-05 20:42 [Bug libstdc++/112397] New: " fxcoudert at gcc dot gnu.org 2023-11-06 9:19 ` [Bug libstdc++/112397] " redi at gcc dot gnu.org 2023-11-06 16:17 ` [Bug target/112397] " iains at gcc dot gnu.org 2024-02-07 17:37 ` iains at gcc dot gnu.org 2024-02-08 12:11 ` redi at gcc dot gnu.org 2024-02-08 12:15 ` redi at gcc dot gnu.org 2024-02-08 12:21 ` jakub at gcc dot gnu.org 2024-02-08 13:12 ` iains at gcc dot gnu.org 2024-02-08 13:18 ` jakub at gcc dot gnu.org 2024-02-08 13:22 ` jakub at gcc dot gnu.org 2024-02-08 14:02 ` iains at gcc dot gnu.org [this message] 2024-02-19 20:16 ` cvs-commit at gcc dot gnu.org 2024-04-03 14:57 ` cvs-commit at gcc dot gnu.org 2024-04-21 13:04 ` cvs-commit at gcc dot gnu.org 2024-04-29 14:18 ` cvs-commit at gcc dot gnu.org 2024-04-29 14:42 ` iains at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-112397-4-CKjWsms2W8@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).