From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id D6ED13858D35; Tue, 21 Nov 2023 20:11:05 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D6ED13858D35 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1700597465; bh=jJDnZxJsEfO1r3ZUpWkQtSTNyrNsTRMw3aGa3INSJ34=; h=From:To:Subject:Date:In-Reply-To:References:From; b=S3XD9Ptzt73rkhDg02g111P0OnybthzAdV1cQ9mLqWw8ku4qzd2HM3G6+sviLkCRm JugDS0Gi5gcNzynmipOKiI3DvcIVegQwB365HHISOnfElRd9OJrMweJHZwfqoGHxjm 3Fd+zfG5HGNmKKf/f8Ng+dJFELXkPeeCv3I8l+B0= From: "cvs-commit at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug middle-end/112406] [14 Regression] Several SPECCPU 2017 benchmarks fail with on internal compiler error: in expand_insn, at optabs.cc:8305 after g:01c18f58d37865d5f3bbe93e666183b54ec608c7 Date: Tue, 21 Nov 2023 20:11:05 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: middle-end X-Bugzilla-Version: 14.0 X-Bugzilla-Keywords: ice-on-valid-code X-Bugzilla-Severity: normal X-Bugzilla-Who: cvs-commit at gcc dot gnu.org X-Bugzilla-Status: REOPENED X-Bugzilla-Resolution: X-Bugzilla-Priority: P1 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: 14.0 X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 List-Id: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D112406 --- Comment #22 from CVS Commits --- The master branch has been updated by Robin Dapp : https://gcc.gnu.org/g:2bbc7f4ef6329df62146fd6d0da5f30750cc72b4 commit r14-5697-g2bbc7f4ef6329df62146fd6d0da5f30750cc72b4 Author: Robin Dapp Date: Tue Nov 21 12:51:12 2023 +0100 vect: Allow reduc_index !=3D 1 for COND_OPs. In PR112406 Tamar found another problem with COND_OP reductions. I wrongly assumed that the reduction variable will always remain in operand 1, just as we create the COND_OP in ifcvt. But of course, addition being commutative, we are free to swap operand 1 and 2 and we end up with e.g. _ifc__60 =3D .COND_ADD (_2, _6, MADPictureC1_lsm.10_25, MADPictureC1_lsm.10_25); which does not pass the asserts I put in place. This patch removes this restriction and allows the reduction index to be 2 as well. gcc/ChangeLog: PR middle-end/112406 * tree-vect-loop.cc (vectorize_fold_left_reduction): Allow reduction index !=3D 1. (vect_transform_reduction): Handle reduction index !=3D 1. gcc/testsuite/ChangeLog: * gcc.target/aarch64/pr112406-2.c: New test.=