public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug target/112411] ICE: SIGSEGV with --param=min-nondebug-insn-uid=2147483647 on powerpc64le-unknown-linux-gnu Date: Wed, 06 Dec 2023 18:51:06 +0000 [thread overview] Message-ID: <bug-112411-4-K6HgdNyIr9@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-112411-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112411 --- Comment #9 from Jakub Jelinek <jakub at gcc dot gnu.org> --- If we wanted to support just INSN_UIDs up to 0x55555554, it could be even just lra_insn_recog_data_len = index * 3U / 2 + 1; Looking around, vec.cc has similar limitation, it uses unsigned rather than int alloc, and ... /* Grow slower when large. */ alloc = (alloc * 3 / 2); /* If this is still too small, set it to the right size. */ if (alloc < desired) alloc = desired; So, my understanding is for vectors up to 0x55555555 elements it will do the expected thing, for larger it will simply reallocate to the desired exact value (i.e. as if it was an exact growth rather than the normal exponential one). Perhaps what we could do in both places use alloc = (alloc * (size_t) 3 / 2); plus the if (alloc < desired) alloc = desired;, such that at least on 64-bit hosts we'd use an exponential growth even after 0x55555555 a little bit, but on 32-bit hosts we'd keep what we do. On the lra side then lra_insn_recog_data_len = index * (size_t) 3 / 2; if (lra_insn_recog_data_len <= index) lra_insn_recog_data_len = index + 1;
next prev parent reply other threads:[~2023-12-06 18:51 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-11-06 18:30 [Bug target/112411] New: " zsojka at seznam dot cz 2023-11-07 8:37 ` [Bug target/112411] " rguenth at gcc dot gnu.org 2023-11-07 8:55 ` linkw at gcc dot gnu.org 2023-11-07 11:02 ` rsandifo at gcc dot gnu.org 2023-11-30 2:35 ` aoliva at gcc dot gnu.org 2023-11-30 8:32 ` zsojka at seznam dot cz 2023-11-30 8:39 ` rguenther at suse dot de 2023-12-06 17:47 ` jakub at gcc dot gnu.org 2023-12-06 18:19 ` jakub at gcc dot gnu.org 2023-12-06 18:51 ` jakub at gcc dot gnu.org [this message] 2023-12-07 7:56 ` [Bug middle-end/112411] " rguenth at gcc dot gnu.org 2023-12-08 7:33 ` cvs-commit at gcc dot gnu.org 2023-12-08 8:01 ` cvs-commit at gcc dot gnu.org 2023-12-08 8:01 ` jakub at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-112411-4-K6HgdNyIr9@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).