[Bug libfortran/112412] New: Masked reduction functions return an unallocated array when the result is empty

public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed

* [Bug libfortran/112412] New: Masked reduction functions return an unallocated array when the result is empty
@ 2023-11-06 19:28 mikael at gcc dot gnu.org
  2023-11-08 11:05 ` [Bug libfortran/112412] " mikael at gcc dot gnu.org
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: mikael at gcc dot gnu.org @ 2023-11-06 19:28 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112412

            Bug ID: 112412
           Summary: Masked reduction functions return an unallocated array
                    when the result is empty
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libfortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: mikael at gcc dot gnu.org
  Target Milestone: ---

Non-masked reduction functions work, but their masked variant don't allocate if
the result is empty, so the result is seen as non-allocated.
See:
https://gcc.gnu.org/pipermail/fortran/2023-November/059902.html

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Bug libfortran/112412] Masked reduction functions return an unallocated array when the result is empty
  2023-11-06 19:28 [Bug libfortran/112412] New: Masked reduction functions return an unallocated array when the result is empty mikael at gcc dot gnu.org
@ 2023-11-08 11:05 ` mikael at gcc dot gnu.org
  2023-11-08 11:32 ` cvs-commit at gcc dot gnu.org
  2023-11-08 11:37 ` mikael at gcc dot gnu.org
  2 siblings, 0 replies; 4+ messages in thread
From: mikael at gcc dot gnu.org @ 2023-11-08 11:05 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112412

Mikael Morin <mikael at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2023-11-08
           Assignee|unassigned at gcc dot gnu.org      |mikael at gcc dot gnu.org

--- Comment #1 from Mikael Morin <mikael at gcc dot gnu.org> ---
Patches submitted (and accepted):
https://gcc.gnu.org/pipermail/fortran/2023-November/059904.html
https://gcc.gnu.org/pipermail/gcc-patches/2023-November/635518.html

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Bug libfortran/112412] Masked reduction functions return an unallocated array when the result is empty
  2023-11-06 19:28 [Bug libfortran/112412] New: Masked reduction functions return an unallocated array when the result is empty mikael at gcc dot gnu.org
  2023-11-08 11:05 ` [Bug libfortran/112412] " mikael at gcc dot gnu.org
@ 2023-11-08 11:32 ` cvs-commit at gcc dot gnu.org
  2023-11-08 11:37 ` mikael at gcc dot gnu.org
  2 siblings, 0 replies; 4+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2023-11-08 11:32 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112412

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Mikael Morin <mikael@gcc.gnu.org>:

https://gcc.gnu.org/g:d56bf419453ad44e53b05a9de22e98f6a80b5efd

commit r14-5244-gd56bf419453ad44e53b05a9de22e98f6a80b5efd
Author: Mikael Morin <mikael@gcc.gnu.org>
Date:   Tue Nov 7 11:24:02 2023 +0100

    libgfortran: Don't skip allocation if size is zero [PR112412]

    In the function template of transformational functions doing a reduction
    of an array along one dimension, if the passed in result array was
    unallocated and the calculated allocation size was zero (this is the case
    of empty result arrays), an early return used to skip the allocation.  This
    change moves the allocation before the early return, so that empty result
    arrays are not seen as unallocated.  This is possible because zero size is
    explicitly supported by the allocation function.

    The offending code is present in several places, and this updates them all.
    More precisely, there is one place in the template for logical reductions,
    and there are two places in the templates corresponding to masked
reductions
    with respectively array mask and scalar mask.  Templates for unmasked
    reductions, which already allocate before returning, are not affected, but
    unmasked reductions are checked nevertheless in the testcase.  The affected
    m4 files are ifunction.m4 for regular functions and types, ifunction-s.m4
    for character minloc and maxloc, ifunction-s2.m4 for character minval and
    maxval, and ifunction_logical for logical reductions.

            PR fortran/112412

    libgfortran/ChangeLog:

            * m4/ifunction.m4 (START_MASKED_ARRAY_FUNCTION,
SCALAR_ARRAY_FUNCTION):
            Don't skip allocation if the allocation size is zero.
            * m4/ifunction-s.m4 (START_MASKED_ARRAY_FUNCTION,
            SCALAR_ARRAY_FUNCTION): Ditto.
            * m4/ifunction-s2.m4 (START_MASKED_ARRAY_FUNCTION,
            SCALAR_ARRAY_FUNCTION): Ditto.
            * m4/ifunction_logical.m4 (START_ARRAY_FUNCTION): Ditto.
            * generated/all_l1.c: Regenerate.
            * generated/all_l16.c: Regenerate.
            * generated/all_l2.c: Regenerate.
            * generated/all_l4.c: Regenerate.
            * generated/all_l8.c: Regenerate.
            * generated/any_l1.c: Regenerate.
            * generated/any_l16.c: Regenerate.
            * generated/any_l2.c: Regenerate.
            * generated/any_l4.c: Regenerate.
            * generated/any_l8.c: Regenerate.
            * generated/count_16_l.c: Regenerate.
            * generated/count_1_l.c: Regenerate.
            * generated/count_2_l.c: Regenerate.
            * generated/count_4_l.c: Regenerate.
            * generated/count_8_l.c: Regenerate.
            * generated/iall_i1.c: Regenerate.
            * generated/iall_i16.c: Regenerate.
            * generated/iall_i2.c: Regenerate.
            * generated/iall_i4.c: Regenerate.
            * generated/iall_i8.c: Regenerate.
            * generated/iany_i1.c: Regenerate.
            * generated/iany_i16.c: Regenerate.
            * generated/iany_i2.c: Regenerate.
            * generated/iany_i4.c: Regenerate.
            * generated/iany_i8.c: Regenerate.
            * generated/iparity_i1.c: Regenerate.
            * generated/iparity_i16.c: Regenerate.
            * generated/iparity_i2.c: Regenerate.
            * generated/iparity_i4.c: Regenerate.
            * generated/iparity_i8.c: Regenerate.
            * generated/maxloc1_16_i1.c: Regenerate.
            * generated/maxloc1_16_i16.c: Regenerate.
            * generated/maxloc1_16_i2.c: Regenerate.
            * generated/maxloc1_16_i4.c: Regenerate.
            * generated/maxloc1_16_i8.c: Regenerate.
            * generated/maxloc1_16_r10.c: Regenerate.
            * generated/maxloc1_16_r16.c: Regenerate.
            * generated/maxloc1_16_r17.c: Regenerate.
            * generated/maxloc1_16_r4.c: Regenerate.
            * generated/maxloc1_16_r8.c: Regenerate.
            * generated/maxloc1_16_s1.c: Regenerate.
            * generated/maxloc1_16_s4.c: Regenerate.
            * generated/maxloc1_4_i1.c: Regenerate.
            * generated/maxloc1_4_i16.c: Regenerate.
            * generated/maxloc1_4_i2.c: Regenerate.
            * generated/maxloc1_4_i4.c: Regenerate.
            * generated/maxloc1_4_i8.c: Regenerate.
            * generated/maxloc1_4_r10.c: Regenerate.
            * generated/maxloc1_4_r16.c: Regenerate.
            * generated/maxloc1_4_r17.c: Regenerate.
            * generated/maxloc1_4_r4.c: Regenerate.
            * generated/maxloc1_4_r8.c: Regenerate.
            * generated/maxloc1_4_s1.c: Regenerate.
            * generated/maxloc1_4_s4.c: Regenerate.
            * generated/maxloc1_8_i1.c: Regenerate.
            * generated/maxloc1_8_i16.c: Regenerate.
            * generated/maxloc1_8_i2.c: Regenerate.
            * generated/maxloc1_8_i4.c: Regenerate.
            * generated/maxloc1_8_i8.c: Regenerate.
            * generated/maxloc1_8_r10.c: Regenerate.
            * generated/maxloc1_8_r16.c: Regenerate.
            * generated/maxloc1_8_r17.c: Regenerate.
            * generated/maxloc1_8_r4.c: Regenerate.
            * generated/maxloc1_8_r8.c: Regenerate.
            * generated/maxloc1_8_s1.c: Regenerate.
            * generated/maxloc1_8_s4.c: Regenerate.
            * generated/maxval1_s1.c: Regenerate.
            * generated/maxval1_s4.c: Regenerate.
            * generated/maxval_i1.c: Regenerate.
            * generated/maxval_i16.c: Regenerate.
            * generated/maxval_i2.c: Regenerate.
            * generated/maxval_i4.c: Regenerate.
            * generated/maxval_i8.c: Regenerate.
            * generated/maxval_r10.c: Regenerate.
            * generated/maxval_r16.c: Regenerate.
            * generated/maxval_r17.c: Regenerate.
            * generated/maxval_r4.c: Regenerate.
            * generated/maxval_r8.c: Regenerate.
            * generated/minloc1_16_i1.c: Regenerate.
            * generated/minloc1_16_i16.c: Regenerate.
            * generated/minloc1_16_i2.c: Regenerate.
            * generated/minloc1_16_i4.c: Regenerate.
            * generated/minloc1_16_i8.c: Regenerate.
            * generated/minloc1_16_r10.c: Regenerate.
            * generated/minloc1_16_r16.c: Regenerate.
            * generated/minloc1_16_r17.c: Regenerate.
            * generated/minloc1_16_r4.c: Regenerate.
            * generated/minloc1_16_r8.c: Regenerate.
            * generated/minloc1_16_s1.c: Regenerate.
            * generated/minloc1_16_s4.c: Regenerate.
            * generated/minloc1_4_i1.c: Regenerate.
            * generated/minloc1_4_i16.c: Regenerate.
            * generated/minloc1_4_i2.c: Regenerate.
            * generated/minloc1_4_i4.c: Regenerate.
            * generated/minloc1_4_i8.c: Regenerate.
            * generated/minloc1_4_r10.c: Regenerate.
            * generated/minloc1_4_r16.c: Regenerate.
            * generated/minloc1_4_r17.c: Regenerate.
            * generated/minloc1_4_r4.c: Regenerate.
            * generated/minloc1_4_r8.c: Regenerate.
            * generated/minloc1_4_s1.c: Regenerate.
            * generated/minloc1_4_s4.c: Regenerate.
            * generated/minloc1_8_i1.c: Regenerate.
            * generated/minloc1_8_i16.c: Regenerate.
            * generated/minloc1_8_i2.c: Regenerate.
            * generated/minloc1_8_i4.c: Regenerate.
            * generated/minloc1_8_i8.c: Regenerate.
            * generated/minloc1_8_r10.c: Regenerate.
            * generated/minloc1_8_r16.c: Regenerate.
            * generated/minloc1_8_r17.c: Regenerate.
            * generated/minloc1_8_r4.c: Regenerate.
            * generated/minloc1_8_r8.c: Regenerate.
            * generated/minloc1_8_s1.c: Regenerate.
            * generated/minloc1_8_s4.c: Regenerate.
            * generated/minval1_s1.c: Regenerate.
            * generated/minval1_s4.c: Regenerate.
            * generated/minval_i1.c: Regenerate.
            * generated/minval_i16.c: Regenerate.
            * generated/minval_i2.c: Regenerate.
            * generated/minval_i4.c: Regenerate.
            * generated/minval_i8.c: Regenerate.
            * generated/minval_r10.c: Regenerate.
            * generated/minval_r16.c: Regenerate.
            * generated/minval_r17.c: Regenerate.
            * generated/minval_r4.c: Regenerate.
            * generated/minval_r8.c: Regenerate.
            * generated/product_c10.c: Regenerate.
            * generated/product_c16.c: Regenerate.
            * generated/product_c17.c: Regenerate.
            * generated/product_c4.c: Regenerate.
            * generated/product_c8.c: Regenerate.
            * generated/product_i1.c: Regenerate.
            * generated/product_i16.c: Regenerate.
            * generated/product_i2.c: Regenerate.
            * generated/product_i4.c: Regenerate.
            * generated/product_i8.c: Regenerate.
            * generated/product_r10.c: Regenerate.
            * generated/product_r16.c: Regenerate.
            * generated/product_r17.c: Regenerate.
            * generated/product_r4.c: Regenerate.
            * generated/product_r8.c: Regenerate.
            * generated/sum_c10.c: Regenerate.
            * generated/sum_c16.c: Regenerate.
            * generated/sum_c17.c: Regenerate.
            * generated/sum_c4.c: Regenerate.
            * generated/sum_c8.c: Regenerate.
            * generated/sum_i1.c: Regenerate.
            * generated/sum_i16.c: Regenerate.
            * generated/sum_i2.c: Regenerate.
            * generated/sum_i4.c: Regenerate.
            * generated/sum_i8.c: Regenerate.
            * generated/sum_r10.c: Regenerate.
            * generated/sum_r16.c: Regenerate.
            * generated/sum_r17.c: Regenerate.
            * generated/sum_r4.c: Regenerate.
            * generated/sum_r8.c: Regenerate.

    gcc/testsuite/ChangeLog:

            * gfortran.dg/allocated_4.f90: New test.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Bug libfortran/112412] Masked reduction functions return an unallocated array when the result is empty
  2023-11-06 19:28 [Bug libfortran/112412] New: Masked reduction functions return an unallocated array when the result is empty mikael at gcc dot gnu.org
  2023-11-08 11:05 ` [Bug libfortran/112412] " mikael at gcc dot gnu.org
  2023-11-08 11:32 ` cvs-commit at gcc dot gnu.org
@ 2023-11-08 11:37 ` mikael at gcc dot gnu.org
  2 siblings, 0 replies; 4+ messages in thread
From: mikael at gcc dot gnu.org @ 2023-11-08 11:37 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112412

Mikael Morin <mikael at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Mikael Morin <mikael at gcc dot gnu.org> ---
Fixed for gfortran 14.1, closing.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-11-08 11:37 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-06 19:28 [Bug libfortran/112412] New: Masked reduction functions return an unallocated array when the result is empty mikael at gcc dot gnu.org
2023-11-08 11:05 ` [Bug libfortran/112412] " mikael at gcc dot gnu.org
2023-11-08 11:32 ` cvs-commit at gcc dot gnu.org
2023-11-08 11:37 ` mikael at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).