public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "juzhe.zhong at rivai dot ai" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug c/112431] New: RISC-V GCC-15 feature: Support register overlap on widen RVV instructions Date: Wed, 08 Nov 2023 00:15:18 +0000 [thread overview] Message-ID: <bug-112431-4@http.gcc.gnu.org/bugzilla/> (raw) https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112431 Bug ID: 112431 Summary: RISC-V GCC-15 feature: Support register overlap on widen RVV instructions Product: gcc Version: 14.0 Status: UNCONFIRMED Severity: normal Priority: P3 Component: c Assignee: unassigned at gcc dot gnu.org Reporter: juzhe.zhong at rivai dot ai Target Milestone: --- According to RVV ISA: "The destination EEW is smaller than the source EEW and the overlap is in the lowest-numbered part of the source register group (e.g., when LMUL=1, vnsrl.wi v0, v0, 3 is legal, but a destination of v1 is not)." It's nice that we can support register overlap currently for narrow operations. Consider this following example: #include "riscv_vector.h" void f20 (int16_t *base,int8_t *out,size_t vl, size_t shift) { vuint16m2_t src = __riscv_vle16_v_u16m2 (base, vl); /* Only allow load v30,v31. */ asm volatile("#" :: : "v0", "v1", "v2", "v3", "v4", "v5", "v6", "v7", "v8", "v9", "v10", "v11", "v12", "v13", "v14", "v15", "v16", "v17", "v18", "v19", "v20", "v21", "v22", "v23", "v24", "v25", "v26", "v27", "v28", "v29"); vuint8m1_t v = __riscv_vnclipu_wx_u8m1(src,shift,0,vl); /* Only allow vncvt SRC == DEST v30. */ asm volatile("#" :: : "v0", "v1", "v2", "v3", "v4", "v5", "v6", "v7", "v8", "v9", "v10", "v11", "v12", "v13", "v14", "v15", "v16", "v17", "v18", "v19", "v20", "v21", "v22", "v23", "v24", "v25", "v26", "v27", "v28", "v29", "v31"); __riscv_vse8_v_u8m1 (out,v,vl); } https://gcc.godbolt.org/z/j98xejKh5 GCC doesn't have register spilling wheras LLVM has register spillings. However, we failed to support register overlap for RVV widen operations. Since according to RVV ISA: "The destination EEW is greater than the source EEW, the source EMUL is at least 1, and the overlap is in the highest-numbered part of the destination register group (e.g., when LMUL=8, vzext.vf4 v0, v6 is legal, but a source of v0, v2, or v4 is not)." Consider this following case: #include "riscv_vector.h" void f20 (void *base,void *out,size_t vl, size_t shift) { vuint16m1_t src = __riscv_vle16_v_u16m1 (base, vl); /* Only allow load v30,v31. */ asm volatile("#" :: : "v0", "v1", "v2", "v3", "v4", "v5", "v6", "v7", "v8", "v9", "v10", "v11", "v12", "v13", "v14", "v15", "v16", "v17", "v18", "v19", "v20", "v21", "v22", "v23", "v24", "v25", "v26", "v27", "v28", "v29", "v30"); vuint32m2_t v = __riscv_vwaddu_vv_u32m2(src,src,vl); /* Only allow vncvt SRC == DEST v30. */ asm volatile("#" :: : "v0", "v1", "v2", "v3", "v4", "v5", "v6", "v7", "v8", "v9", "v10", "v11", "v12", "v13", "v14", "v15", "v16", "v17", "v18", "v19", "v20", "v21", "v22", "v23", "v24", "v25", "v26", "v27", "v28", "v29"); __riscv_vse32_v_u32m2 (out,v,vl); } https://gcc.godbolt.org/z/h3cM9vhnY Since we are configuring RVV widen instructions early clobber, same as LLVM. We can see both LLVM and GCC fail to overlap registers. GCC ASM: f20: vsetvli zero,a2,e16,m1,ta,ma vle16.v v31,0(a0) vwaddu.vv v2,v31,v31 vmv2r.v v30,v2 ----> Redundant mov instruction. vse32.v v30,0(a1) ret We should be able to generate vwaddu.vv v30,v31,v31 which can eliminate the redundant move instruction. This issue will be fixed on GCC-15 since we don't enough time on GCC-14.
next reply other threads:[~2023-11-08 0:15 UTC|newest] Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-11-08 0:15 juzhe.zhong at rivai dot ai [this message] 2023-11-08 0:16 ` [Bug c/112431] " juzhe.zhong at rivai dot ai 2023-11-08 0:16 ` juzhe.zhong at rivai dot ai 2023-11-08 1:56 ` kito at gcc dot gnu.org 2023-11-12 21:18 ` pinskia at gcc dot gnu.org 2023-11-29 9:37 ` [Bug target/112431] " cvs-commit at gcc dot gnu.org 2023-11-30 1:16 ` cvs-commit at gcc dot gnu.org 2023-11-30 2:40 ` cvs-commit at gcc dot gnu.org 2023-11-30 10:50 ` cvs-commit at gcc dot gnu.org 2023-11-30 12:11 ` cvs-commit at gcc dot gnu.org 2023-12-01 12:09 ` cvs-commit at gcc dot gnu.org 2023-12-01 12:09 ` cvs-commit at gcc dot gnu.org 2023-12-04 10:45 ` cvs-commit at gcc dot gnu.org 2023-12-04 11:21 ` juzhe.zhong at rivai dot ai 2023-12-04 13:36 ` cvs-commit at gcc dot gnu.org 2023-12-04 13:48 ` cvs-commit at gcc dot gnu.org 2023-12-11 7:56 ` cvs-commit at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-112431-4@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).