* [Bug middle-end/112444] [14 regression] ICE when buliding libqmi with -O3 -ftrivial-auto-var-init=zero (internal compiler error: tree check: expected class ‘type’, have ‘exceptional’ (error_mark) in useless_type_conversion_p, at gimple-expr.cc:85)
2023-11-08 14:29 [Bug middle-end/112444] New: [14 regression] ICE when buliding libqmi (internal compiler error: tree check: expected class ‘type’, have ‘exceptional’ (error_mark) in useless_type_conversion_p, at gimple-expr.cc:85) sjames at gcc dot gnu.org
@ 2023-11-08 15:26 ` sjames at gcc dot gnu.org
2023-11-09 0:34 ` pinskia at gcc dot gnu.org
` (9 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: sjames at gcc dot gnu.org @ 2023-11-08 15:26 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112444
--- Comment #1 from Sam James <sjames at gcc dot gnu.org> ---
Created attachment 56535
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=56535&action=edit
reduced.i
cvise popped this out, I haven't tried to prettify it by hand at all as heading
out now.
^ permalink raw reply [flat|nested] 12+ messages in thread* [Bug middle-end/112444] [14 regression] ICE when buliding libqmi with -O3 -ftrivial-auto-var-init=zero (internal compiler error: tree check: expected class ‘type’, have ‘exceptional’ (error_mark) in useless_type_conversion_p, at gimple-expr.cc:85)
2023-11-08 14:29 [Bug middle-end/112444] New: [14 regression] ICE when buliding libqmi (internal compiler error: tree check: expected class ‘type’, have ‘exceptional’ (error_mark) in useless_type_conversion_p, at gimple-expr.cc:85) sjames at gcc dot gnu.org
2023-11-08 15:26 ` [Bug middle-end/112444] [14 regression] ICE when buliding libqmi with -O3 -ftrivial-auto-var-init=zero " sjames at gcc dot gnu.org
@ 2023-11-09 0:34 ` pinskia at gcc dot gnu.org
2023-11-09 0:36 ` pinskia at gcc dot gnu.org
` (8 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: pinskia at gcc dot gnu.org @ 2023-11-09 0:34 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112444
--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Created attachment 56543
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=56543&action=edit
little more reduced
^ permalink raw reply [flat|nested] 12+ messages in thread* [Bug middle-end/112444] [14 regression] ICE when buliding libqmi with -O3 -ftrivial-auto-var-init=zero (internal compiler error: tree check: expected class ‘type’, have ‘exceptional’ (error_mark) in useless_type_conversion_p, at gimple-expr.cc:85)
2023-11-08 14:29 [Bug middle-end/112444] New: [14 regression] ICE when buliding libqmi (internal compiler error: tree check: expected class ‘type’, have ‘exceptional’ (error_mark) in useless_type_conversion_p, at gimple-expr.cc:85) sjames at gcc dot gnu.org
2023-11-08 15:26 ` [Bug middle-end/112444] [14 regression] ICE when buliding libqmi with -O3 -ftrivial-auto-var-init=zero " sjames at gcc dot gnu.org
2023-11-09 0:34 ` pinskia at gcc dot gnu.org
@ 2023-11-09 0:36 ` pinskia at gcc dot gnu.org
2023-11-09 0:41 ` pinskia at gcc dot gnu.org
` (7 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: pinskia at gcc dot gnu.org @ 2023-11-09 0:36 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112444
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #56543|0 |1
is obsolete| |
--- Comment #3 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Created attachment 56544
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=56544&action=edit
with no warnings
^ permalink raw reply [flat|nested] 12+ messages in thread* [Bug middle-end/112444] [14 regression] ICE when buliding libqmi with -O3 -ftrivial-auto-var-init=zero (internal compiler error: tree check: expected class ‘type’, have ‘exceptional’ (error_mark) in useless_type_conversion_p, at gimple-expr.cc:85)
2023-11-08 14:29 [Bug middle-end/112444] New: [14 regression] ICE when buliding libqmi (internal compiler error: tree check: expected class ‘type’, have ‘exceptional’ (error_mark) in useless_type_conversion_p, at gimple-expr.cc:85) sjames at gcc dot gnu.org
` (2 preceding siblings ...)
2023-11-09 0:36 ` pinskia at gcc dot gnu.org
@ 2023-11-09 0:41 ` pinskia at gcc dot gnu.org
2023-11-09 0:44 ` pinskia at gcc dot gnu.org
` (6 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: pinskia at gcc dot gnu.org @ 2023-11-09 0:41 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112444
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Ever confirmed|0 |1
Keywords| |ice-on-valid-code
Status|UNCONFIRMED |NEW
Target Milestone|--- |14.0
Last reconfirmed| |2023-11-09
--- Comment #4 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
```
<bb 3> [local count: 57140633]:
# ivtmp_62 = PHI <44(2), ivtmp_72(8)>
_7 = .DEFERRED_INIT (1, 2, &"tmp"[0]);
...
<bb 5> [local count: 57140633]:
# _59 = PHI <_7(3), _54(4)>
<bb 6> [local count: 877722739]:
# ivtmp_8 = PHI <444(5), ivtmp_63(7)>
tmp = _59;
```
defining statement of _54 is nowhere to be found.
Note this ICEs still even with -fno-checking
^ permalink raw reply [flat|nested] 12+ messages in thread* [Bug middle-end/112444] [14 regression] ICE when buliding libqmi with -O3 -ftrivial-auto-var-init=zero (internal compiler error: tree check: expected class ‘type’, have ‘exceptional’ (error_mark) in useless_type_conversion_p, at gimple-expr.cc:85)
2023-11-08 14:29 [Bug middle-end/112444] New: [14 regression] ICE when buliding libqmi (internal compiler error: tree check: expected class ‘type’, have ‘exceptional’ (error_mark) in useless_type_conversion_p, at gimple-expr.cc:85) sjames at gcc dot gnu.org
` (3 preceding siblings ...)
2023-11-09 0:41 ` pinskia at gcc dot gnu.org
@ 2023-11-09 0:44 ` pinskia at gcc dot gnu.org
2023-11-09 1:10 ` [Bug middle-end/112444] [14 regression] ICE when buliding libqmi with -O3 -ftrivial-auto-var-init=zero (internal compiler error: tree check: expected class ‘type’, have ‘exceptional’ (error_mark) in useless_type_conversion_p, at gimple-expr.cc:85) since r14-4405-gb583a2940af90d sjames at gcc dot gnu.org
` (5 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: pinskia at gcc dot gnu.org @ 2023-11-09 0:44 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112444
--- Comment #5 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Note the 2 tmp variables need to be named the same. Otherwise fre won't merge
the 2 ".DEFERRED_INIT (1, 2, &"tmp"[0]);" .
^ permalink raw reply [flat|nested] 12+ messages in thread* [Bug middle-end/112444] [14 regression] ICE when buliding libqmi with -O3 -ftrivial-auto-var-init=zero (internal compiler error: tree check: expected class ‘type’, have ‘exceptional’ (error_mark) in useless_type_conversion_p, at gimple-expr.cc:85) since r14-4405-gb583a2940af90d
2023-11-08 14:29 [Bug middle-end/112444] New: [14 regression] ICE when buliding libqmi (internal compiler error: tree check: expected class ‘type’, have ‘exceptional’ (error_mark) in useless_type_conversion_p, at gimple-expr.cc:85) sjames at gcc dot gnu.org
` (4 preceding siblings ...)
2023-11-09 0:44 ` pinskia at gcc dot gnu.org
@ 2023-11-09 1:10 ` sjames at gcc dot gnu.org
2023-11-09 7:45 ` rguenth at gcc dot gnu.org
` (4 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: sjames at gcc dot gnu.org @ 2023-11-09 1:10 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112444
Sam James <sjames at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |rguenth at gcc dot gnu.org
Summary|[14 regression] ICE when |[14 regression] ICE when
|buliding libqmi with -O3 |buliding libqmi with -O3
|-ftrivial-auto-var-init=zer |-ftrivial-auto-var-init=zer
|o (internal compiler error: |o (internal compiler error:
|tree check: expected class |tree check: expected class
|‘type’, have ‘exceptional’ |‘type’, have ‘exceptional’
|(error_mark) in |(error_mark) in
|useless_type_conversion_p, |useless_type_conversion_p,
|at gimple-expr.cc:85) |at gimple-expr.cc:85) since
| |r14-4405-gb583a2940af90d
--- Comment #6 from Sam James <sjames at gcc dot gnu.org> ---
b583a2940af90d03f535648fef111cb158933f7d is the first bad commit
commit b583a2940af90d03f535648fef111cb158933f7d
Author: Richard Biener <rguenther@suse.de>
Date: Wed Oct 4 15:25:33 2023 +0200
Avoid left around copies when value-numbering BBs
The following makes sure to treat values whose definition we didn't
visit as available since those by definition must dominate the entry
of the region. That avoids unpropagated copies after if-conversion
and resulting SLP discovery fails (which doesn't handle plain copies).
* tree-ssa-sccvn.cc (rpo_elim::eliminate_avail): Not
visited value numbers are available itself.
gcc/tree-ssa-sccvn.cc | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
bisect found first bad commit
i.e. r14-4405-gb583a2940af90d
^ permalink raw reply [flat|nested] 12+ messages in thread* [Bug middle-end/112444] [14 regression] ICE when buliding libqmi with -O3 -ftrivial-auto-var-init=zero (internal compiler error: tree check: expected class ‘type’, have ‘exceptional’ (error_mark) in useless_type_conversion_p, at gimple-expr.cc:85) since r14-4405-gb583a2940af90d
2023-11-08 14:29 [Bug middle-end/112444] New: [14 regression] ICE when buliding libqmi (internal compiler error: tree check: expected class ‘type’, have ‘exceptional’ (error_mark) in useless_type_conversion_p, at gimple-expr.cc:85) sjames at gcc dot gnu.org
` (5 preceding siblings ...)
2023-11-09 1:10 ` [Bug middle-end/112444] [14 regression] ICE when buliding libqmi with -O3 -ftrivial-auto-var-init=zero (internal compiler error: tree check: expected class ‘type’, have ‘exceptional’ (error_mark) in useless_type_conversion_p, at gimple-expr.cc:85) since r14-4405-gb583a2940af90d sjames at gcc dot gnu.org
@ 2023-11-09 7:45 ` rguenth at gcc dot gnu.org
2023-11-09 8:42 ` rguenth at gcc dot gnu.org
` (3 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: rguenth at gcc dot gnu.org @ 2023-11-09 7:45 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112444
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|unassigned at gcc dot gnu.org |rguenth at gcc dot gnu.org
Status|NEW |ASSIGNED
--- Comment #7 from Richard Biener <rguenth at gcc dot gnu.org> ---
I will have a look.
^ permalink raw reply [flat|nested] 12+ messages in thread* [Bug middle-end/112444] [14 regression] ICE when buliding libqmi with -O3 -ftrivial-auto-var-init=zero (internal compiler error: tree check: expected class ‘type’, have ‘exceptional’ (error_mark) in useless_type_conversion_p, at gimple-expr.cc:85) since r14-4405-gb583a2940af90d
2023-11-08 14:29 [Bug middle-end/112444] New: [14 regression] ICE when buliding libqmi (internal compiler error: tree check: expected class ‘type’, have ‘exceptional’ (error_mark) in useless_type_conversion_p, at gimple-expr.cc:85) sjames at gcc dot gnu.org
` (6 preceding siblings ...)
2023-11-09 7:45 ` rguenth at gcc dot gnu.org
@ 2023-11-09 8:42 ` rguenth at gcc dot gnu.org
2023-11-09 10:52 ` cvs-commit at gcc dot gnu.org
` (2 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: rguenth at gcc dot gnu.org @ 2023-11-09 8:42 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112444
--- Comment #8 from Richard Biener <rguenth at gcc dot gnu.org> ---
OK, so the reason is that we value-number tmp_46 in
<bb 3> [local count: 482002707]:
if (0 != 0)
goto <bb 5>; [33.00%]
else
goto <bb 4>; [67.00%]
<bb 4> [local count: 322941815]:
tmp_5 = .DEFERRED_INIT (1, 2, &"tmp"[0]);
...
goto <bb 6>;
<bb 5> [local count: 159060893]:
...
tmp_2 = .DEFERRED_INIT (1, 2, &"tmp"[0]);
...
tmp_46 = PHI <tmp_5(4), tmp_2(5)>
to tmp_2 because we use ssa_undefined_value_p () to check whether we are
dealing with an undefined value. And that returns true for tmp_5. This
makes us pick tmp_2 which we treat as VARYING since we didn't visit it
and we don't trust the not-executable state of its incoming edge (a missed
optimization, guess I can look at that as well). tmp_2 is also considered
undefined. We then have
/* If we saw only undefined values and VN_TOP use one of the
undefined values. */
else if (sameval == VN_TOP)
result = seen_undef ? seen_undef : sameval;
and "one of" puts us in an unlucky situation here.
I do have a sensible fix around this I think.
^ permalink raw reply [flat|nested] 12+ messages in thread* [Bug middle-end/112444] [14 regression] ICE when buliding libqmi with -O3 -ftrivial-auto-var-init=zero (internal compiler error: tree check: expected class ‘type’, have ‘exceptional’ (error_mark) in useless_type_conversion_p, at gimple-expr.cc:85) since r14-4405-gb583a2940af90d
2023-11-08 14:29 [Bug middle-end/112444] New: [14 regression] ICE when buliding libqmi (internal compiler error: tree check: expected class ‘type’, have ‘exceptional’ (error_mark) in useless_type_conversion_p, at gimple-expr.cc:85) sjames at gcc dot gnu.org
` (7 preceding siblings ...)
2023-11-09 8:42 ` rguenth at gcc dot gnu.org
@ 2023-11-09 10:52 ` cvs-commit at gcc dot gnu.org
2023-11-09 10:52 ` rguenth at gcc dot gnu.org
2023-12-12 7:16 ` rguenth at gcc dot gnu.org
10 siblings, 0 replies; 12+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2023-11-09 10:52 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112444
--- Comment #9 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Richard Biener <rguenth@gcc.gnu.org>:
https://gcc.gnu.org/g:8ebcea91e24964ec52ca2caf9f8585f3a785f7d5
commit r14-5276-g8ebcea91e24964ec52ca2caf9f8585f3a785f7d5
Author: Richard Biener <rguenther@suse.de>
Date: Thu Nov 9 09:41:10 2023 +0100
tree-optimization/112444 - avoid bougs PHI value-numbering
With .DEFERRED_INIT ssa_undefined_value_p () can return true for
values we did not visit (because they proved unreachable) but
are not .VN_TOP. Avoid using those as value which, because they
are not visited, are assumed to be defined outside of the region.
PR tree-optimization/112444
* tree-ssa-sccvn.cc (visit_phi): Avoid using not visited
defs as undefined vals.
* gcc.dg/torture/pr112444.c: New testcase.
^ permalink raw reply [flat|nested] 12+ messages in thread* [Bug middle-end/112444] [14 regression] ICE when buliding libqmi with -O3 -ftrivial-auto-var-init=zero (internal compiler error: tree check: expected class ‘type’, have ‘exceptional’ (error_mark) in useless_type_conversion_p, at gimple-expr.cc:85) since r14-4405-gb583a2940af90d
2023-11-08 14:29 [Bug middle-end/112444] New: [14 regression] ICE when buliding libqmi (internal compiler error: tree check: expected class ‘type’, have ‘exceptional’ (error_mark) in useless_type_conversion_p, at gimple-expr.cc:85) sjames at gcc dot gnu.org
` (8 preceding siblings ...)
2023-11-09 10:52 ` cvs-commit at gcc dot gnu.org
@ 2023-11-09 10:52 ` rguenth at gcc dot gnu.org
2023-12-12 7:16 ` rguenth at gcc dot gnu.org
10 siblings, 0 replies; 12+ messages in thread
From: rguenth at gcc dot gnu.org @ 2023-11-09 10:52 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112444
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
--- Comment #10 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed.
^ permalink raw reply [flat|nested] 12+ messages in thread* [Bug middle-end/112444] [14 regression] ICE when buliding libqmi with -O3 -ftrivial-auto-var-init=zero (internal compiler error: tree check: expected class ‘type’, have ‘exceptional’ (error_mark) in useless_type_conversion_p, at gimple-expr.cc:85) since r14-4405-gb583a2940af90d
2023-11-08 14:29 [Bug middle-end/112444] New: [14 regression] ICE when buliding libqmi (internal compiler error: tree check: expected class ‘type’, have ‘exceptional’ (error_mark) in useless_type_conversion_p, at gimple-expr.cc:85) sjames at gcc dot gnu.org
` (9 preceding siblings ...)
2023-11-09 10:52 ` rguenth at gcc dot gnu.org
@ 2023-12-12 7:16 ` rguenth at gcc dot gnu.org
10 siblings, 0 replies; 12+ messages in thread
From: rguenth at gcc dot gnu.org @ 2023-12-12 7:16 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112444
Bug 112444 depends on bug 112939, which changed state.
Bug 112939 Summary: [14 Regression] ICE: verify_ssa failed with -O -ftrivial-auto-var-init=zero
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112939
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
^ permalink raw reply [flat|nested] 12+ messages in thread