public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/112444] [14 regression] ICE when buliding libqmi with -O3 -ftrivial-auto-var-init=zero (internal compiler error: tree check: expected class ‘type’, have ‘exceptional’ (error_mark) in useless_type_conversion_p, at gimple-expr.cc:85) since r14-4405-gb583a2940af90d
Date: Thu, 09 Nov 2023 08:42:53 +0000	[thread overview]
Message-ID: <bug-112444-4-epg3UtzkTw@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-112444-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112444

--- Comment #8 from Richard Biener <rguenth at gcc dot gnu.org> ---
OK, so the reason is that we value-number tmp_46 in

<bb 3> [local count: 482002707]:
if (0 != 0)
  goto <bb 5>; [33.00%]
else
  goto <bb 4>; [67.00%]

<bb 4> [local count: 322941815]:
tmp_5 = .DEFERRED_INIT (1, 2, &"tmp"[0]);
...
goto <bb 6>;

<bb 5> [local count: 159060893]:
...
tmp_2 = .DEFERRED_INIT (1, 2, &"tmp"[0]);
...

tmp_46 = PHI <tmp_5(4), tmp_2(5)>

to tmp_2 because we use ssa_undefined_value_p () to check whether we are
dealing with an undefined value.  And that returns true for tmp_5.  This
makes us pick tmp_2 which we treat as VARYING since we didn't visit it
and we don't trust the not-executable state of its incoming edge (a missed
optimization, guess I can look at that as well).  tmp_2 is also considered
undefined.  We then have

  /* If we saw only undefined values and VN_TOP use one of the
     undefined values.  */
  else if (sameval == VN_TOP)
    result = seen_undef ? seen_undef : sameval;

and "one of" puts us in an unlucky situation here.

I do have a sensible fix around this I think.

  parent reply	other threads:[~2023-11-09  8:42 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-08 14:29 [Bug middle-end/112444] New: [14 regression] ICE when buliding libqmi (internal compiler error: tree check: expected class ‘type’, have ‘exceptional’ (error_mark) in useless_type_conversion_p, at gimple-expr.cc:85) sjames at gcc dot gnu.org
2023-11-08 15:26 ` [Bug middle-end/112444] [14 regression] ICE when buliding libqmi with -O3 -ftrivial-auto-var-init=zero " sjames at gcc dot gnu.org
2023-11-09  0:34 ` pinskia at gcc dot gnu.org
2023-11-09  0:36 ` pinskia at gcc dot gnu.org
2023-11-09  0:41 ` pinskia at gcc dot gnu.org
2023-11-09  0:44 ` pinskia at gcc dot gnu.org
2023-11-09  1:10 ` [Bug middle-end/112444] [14 regression] ICE when buliding libqmi with -O3 -ftrivial-auto-var-init=zero (internal compiler error: tree check: expected class ‘type’, have ‘exceptional’ (error_mark) in useless_type_conversion_p, at gimple-expr.cc:85) since r14-4405-gb583a2940af90d sjames at gcc dot gnu.org
2023-11-09  7:45 ` rguenth at gcc dot gnu.org
2023-11-09  8:42 ` rguenth at gcc dot gnu.org [this message]
2023-11-09 10:52 ` cvs-commit at gcc dot gnu.org
2023-11-09 10:52 ` rguenth at gcc dot gnu.org
2023-12-12  7:16 ` rguenth at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-112444-4-epg3UtzkTw@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).