[Bug ada/112514] New: All ACATS tests fail on trunk

[Bug ada/112514] New: All ACATS tests fail on trunk

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112514

            Bug ID: 112514
           Summary: All ACATS tests fail on trunk
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: ada
          Assignee: unassigned at gcc dot gnu.org
          Reporter: rguenth at gcc dot gnu.org
                CC: dkm at gcc dot gnu.org
  Target Milestone: ---

With r14-5387-gb51bfee1beed03 (not bisected) I see 

                === acats tests ===
FAIL:   a22006b
FAIL:   a22006c
...
                === acats Summary ===
# of expected passes            0
# of unexpected failures        2328
Native configuration is x86_64-pc-linux-gnu

and a two gnat test fail:

                === gnat tests ===


Running target unix/
FAIL: gnat.dg/in_out_parameter.adb execution test
FAIL: gnat.dg/test_direct_io.adb execution test

the FAILs are unconclusive:

Running chapter a ...
splitting /home/rguenther/obj/gcc/testsuite/ada/acats1/tests/a/a22006b.ada
into:
raised STORAGE_ERROR : stack overflow or erroneous memory access
BUILD 
FAIL:   a22006b

but suggest an error in the gnat tools?

[Bug ada/112514] All ACATS tests fail on trunk

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112514

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Target|                            |x86_64-linux-gnu

--- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> ---
The test_direct_io.adb test segfaults in

Program received signal SIGSEGV, Segmentation fault.
system.file_io.open (file_ptr=<optimized out>, dummy_fcb=..., mode=<optimized
out>, name=..., form=..., amethod=amethod@entry=68 'D', creat=true, text=false,
c_stream=0) at s-fileio.adb:862
862           Formstr (Formstr'Last) := ASCII.NUL;
(gdb) bt
#0  system.file_io.open (file_ptr=<optimized out>, dummy_fcb=..., 
    mode=<optimized out>, name=..., form=..., amethod=amethod@entry=68 'D', 
    creat=true, text=false, c_stream=0) at s-fileio.adb:862
#1  0x0000000000422963 in system.direct_io.create (file=<optimized out>, 
    mode=<optimized out>, name=..., form=...) at s-direio.adb:112
#2  0x0000000000422e33 in test_direct_io.bdio.create (file=0x0, 
    mode=inout_file, name=..., form=...)
    at
/home/rguenther/obj/x86_64-pc-linux-gnu/./libada/adainclude/a-direio.adb:86
#3  0x0000000000422d8c in test_direct_io ()
    at /home/rguenther/gcc/gcc/testsuite/gnat.dg/test_direct_io.adb:12

[Bug ada/112514] [14 Regression] All ACATS tests fail on trunk

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112514

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://gcc.gnu.org/bugzill
                   |                            |a/show_bug.cgi?id=112523
   Target Milestone|---                         |14.0
           Keywords|                            |wrong-code
            Summary|All ACATS tests fail on     |[14 Regression] All ACATS
                   |trunk                       |tests fail on trunk

--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Could be 
https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=0a140730c970870a5125beb1114f6c01679a040e
(which has caused other issues on x86_64, see PR 112523 for an example).

[Bug ada/112514] [14 Regression] All ACATS tests fail on trunk after r14-5385-g0a140730c97087

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112514

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2023-11-14
            Summary|[14 Regression] All ACATS   |[14 Regression] All ACATS
                   |tests fail on trunk         |tests fail on trunk after
                   |                            |r14-5385-g0a140730c97087

--- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> ---
Caused by r14-5385-g0a140730c97087.

[Bug ada/112514] [14 Regression] All ACATS tests fail on trunk after r14-5385-g0a140730c97087

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112514

--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Trying
2023-11-14  Jakub Jelinek  <jakub@redhat.com>

        * config/i386/i386.md (<insn><dwi>3_doubleword_lowpart): Move
        operands[1] aka low part of input rather than operands[3] aka high
        part of input to output if not the same register.

--- gcc/config/i386/i386.md.jj  2023-11-14 08:10:18.932549803 +0100
+++ gcc/config/i386/i386.md     2023-11-14 09:31:05.565019207 +0100
@@ -14825,8 +14825,8 @@ (define_insn_and_split "<insn><dwi>3_dou
 {
   split_double_mode (<DWI>mode, &operands[1], 1, &operands[1], &operands[3]);
   operands[4] = GEN_INT ((<MODE_SIZE> * BITS_PER_UNIT) - INTVAL
(operands[2]));
-  if (!rtx_equal_p (operands[0], operands[3]))
-    emit_move_insn (operands[0], operands[3]);
+  if (!rtx_equal_p (operands[0], operands[1]))
+    emit_move_insn (operands[0], operands[1]);
 })

 (define_insn "x86_64_shrd"
now if it fixes this.

[Bug ada/112514] [14 Regression] All ACATS tests fail on trunk after r14-5385-g0a140730c97087

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112514

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:aad65285a1c681feb9fc5b041c86d841b24c3d2a

commit r14-5442-gaad65285a1c681feb9fc5b041c86d841b24c3d2a
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Tue Nov 14 13:19:48 2023 +0100

    i386: Fix up <insn><dwi>3_doubleword_lowpart [PR112523]

    On Sun, Nov 12, 2023 at 09:03:42PM -0000, Roger Sayle wrote:
    > This patch improves register pressure during reload, inspired by PR
97756.
    > Normally, a double-word right-shift by a constant produces a double-word
    > result, the highpart of which is dead when followed by a truncation.
    > The dead code calculating the high part gets cleaned up post-reload, so
    > the issue isn't normally visible, except for the increased register
    > pressure during reload, sometimes leading to odd register assignments.
    > Providing a post-reload splitter, which clobbers a single wordmode
    > result register instead of a doubleword result register, helps (a bit).

    Unfortunately this broke bootstrap on i686-linux, broke all ACATS tests
    on x86_64-linux as well as miscompiled e.g. __floattisf in libgcc there
    as well.

    The bug is that shrd{l,q} instruction expects the low part of the input
    to be the same register as the output, rather than the high part as the
    patch implemented.
      split_double_mode (<DWI>mode, &operands[1], 1, &operands[1],
&operands[3]);
    sets operands[1] to the lo_half and operands[3] to the hi_half, so if
    operands[0] is not the same register as operands[1] (rather than [3]) after
    RA, we should during splitting move operands[1] into operands[0].

    Your testcase:
    > #define MASK60 ((1ul << 60) - 1)
    > unsigned long foo (__uint128_t n)
    > {
    >   unsigned long a = n & MASK60;
    >   unsigned long b = (n >> 60);
    >   b = b & MASK60;
    >   unsigned long c = (n >> 120);
    >   return a+b+c;
    > }

    still has the same number of instructions.

    Bootstrapped/regtested on x86_64-linux (where it e.g. turns
                    === acats Summary ===
    -# of unexpected failures       2328
    +# of expected passes           2328
    +# of unexpected failures       0
    and fixes gcc.dg/torture/fp-int-convert-*timode.c FAILs as well)
    and i686-linux (where it previously didn't bootstrap, but compared to
    Friday evening's bootstrap the testresults are ok).

    2023-11-14  Jakub Jelinek  <jakub@redhat.com>

            PR target/112523
            PR ada/112514
            * config/i386/i386.md (<insn><dwi>3_doubleword_lowpart): Move
            operands[1] aka low part of input rather than operands[3] aka high
            part of input to output if not the same register.

[Bug ada/112514] [14 Regression] All ACATS tests fail on trunk after r14-5385-g0a140730c97087

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112514

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #6 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Fixed.