public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug target/112518] New: [14 Regression] wrong code with __builtin_mul_overflow_p() on x86_64-pc-linux-gnu
@ 2023-11-13 19:34 zsojka at seznam dot cz
2023-11-13 19:44 ` [Bug target/112518] " pinskia at gcc dot gnu.org
` (10 more replies)
0 siblings, 11 replies; 12+ messages in thread
From: zsojka at seznam dot cz @ 2023-11-13 19:34 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112518
Bug ID: 112518
Summary: [14 Regression] wrong code with
__builtin_mul_overflow_p() on x86_64-pc-linux-gnu
Product: gcc
Version: 14.0
Status: UNCONFIRMED
Keywords: wrong-code
Severity: normal
Priority: P3
Component: target
Assignee: unassigned at gcc dot gnu.org
Reporter: zsojka at seznam dot cz
Target Milestone: ---
Host: x86_64-pc-linux-gnu
Target: x86_64-pc-linux-gnu
Created attachment 56574
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=56574&action=edit
reduced testcase
Output:
$ x86_64-pc-linux-gnu-gcc -Os -mbmi testcase.c
$ ./a.out
Aborted
$ x86_64-pc-linux-gnu-gcc -v
Using built-in specs.
COLLECT_GCC=/repo/gcc-trunk/binary-latest-amd64/bin/x86_64-pc-linux-gnu-gcc
COLLECT_LTO_WRAPPER=/repo/gcc-trunk/binary-trunk-r14-5417-20231113162111-g2020bce38cf-checking-yes-rtl-df-extra-nobootstrap-amd64/bin/../libexec/gcc/x86_64-pc-linux-gnu/14.0.0/lto-wrapper
Target: x86_64-pc-linux-gnu
Configured with: /repo/gcc-trunk//configure --enable-languages=c,c++
--enable-valgrind-annotations --disable-nls --enable-checking=yes,rtl,df,extra
--disable-bootstrap --with-cloog --with-ppl --with-isl
--build=x86_64-pc-linux-gnu --host=x86_64-pc-linux-gnu
--target=x86_64-pc-linux-gnu --with-ld=/usr/bin/x86_64-pc-linux-gnu-ld
--with-as=/usr/bin/x86_64-pc-linux-gnu-as --disable-libstdcxx-pch
--prefix=/repo/gcc-trunk//binary-trunk-r14-5417-20231113162111-g2020bce38cf-checking-yes-rtl-df-extra-nobootstrap-amd64
Thread model: posix
Supported LTO compression algorithms: zlib zstd
gcc version 14.0.0 20231109 (experimental) (GCC)
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug target/112518] [14 Regression] wrong code with __builtin_mul_overflow_p() on x86_64-pc-linux-gnu
2023-11-13 19:34 [Bug target/112518] New: [14 Regression] wrong code with __builtin_mul_overflow_p() on x86_64-pc-linux-gnu zsojka at seznam dot cz
@ 2023-11-13 19:44 ` pinskia at gcc dot gnu.org
2023-11-13 19:45 ` [Bug target/112518] [14 Regression] wrong code with __builtin_mul_overflow_p() and int128_t " pinskia at gcc dot gnu.org
` (9 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: pinskia at gcc dot gnu.org @ 2023-11-13 19:44 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112518
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |14.0
--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
After r14-5371-g93e92b2e5d6866 .
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug target/112518] [14 Regression] wrong code with __builtin_mul_overflow_p() and int128_t on x86_64-pc-linux-gnu
2023-11-13 19:34 [Bug target/112518] New: [14 Regression] wrong code with __builtin_mul_overflow_p() on x86_64-pc-linux-gnu zsojka at seznam dot cz
2023-11-13 19:44 ` [Bug target/112518] " pinskia at gcc dot gnu.org
@ 2023-11-13 19:45 ` pinskia at gcc dot gnu.org
2023-11-14 23:36 ` pinskia at gcc dot gnu.org
` (8 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: pinskia at gcc dot gnu.org @ 2023-11-13 19:45 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112518
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|[14 Regression] wrong code |[14 Regression] wrong code
|with |with
|__builtin_mul_overflow_p() |__builtin_mul_overflow_p()
|on x86_64-pc-linux-gnu |and int128_t on
| |x86_64-pc-linux-gnu
--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Maybe:
https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=0a140730c970870a5125beb1114f6c01679a040e
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug target/112518] [14 Regression] wrong code with __builtin_mul_overflow_p() and int128_t on x86_64-pc-linux-gnu
2023-11-13 19:34 [Bug target/112518] New: [14 Regression] wrong code with __builtin_mul_overflow_p() on x86_64-pc-linux-gnu zsojka at seznam dot cz
2023-11-13 19:44 ` [Bug target/112518] " pinskia at gcc dot gnu.org
2023-11-13 19:45 ` [Bug target/112518] [14 Regression] wrong code with __builtin_mul_overflow_p() and int128_t " pinskia at gcc dot gnu.org
@ 2023-11-14 23:36 ` pinskia at gcc dot gnu.org
2023-11-15 3:48 ` zsojka at seznam dot cz
` (7 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: pinskia at gcc dot gnu.org @ 2023-11-14 23:36 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112518
--- Comment #3 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
I cannot reproduce it with r14-5450-g4db820928065ec or r14-5427-gd22b87864e5d47
.
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug target/112518] [14 Regression] wrong code with __builtin_mul_overflow_p() and int128_t on x86_64-pc-linux-gnu
2023-11-13 19:34 [Bug target/112518] New: [14 Regression] wrong code with __builtin_mul_overflow_p() on x86_64-pc-linux-gnu zsojka at seznam dot cz
` (2 preceding siblings ...)
2023-11-14 23:36 ` pinskia at gcc dot gnu.org
@ 2023-11-15 3:48 ` zsojka at seznam dot cz
2023-11-18 6:23 ` pinskia at gcc dot gnu.org
` (6 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: zsojka at seznam dot cz @ 2023-11-15 3:48 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112518
--- Comment #4 from Zdenek Sojka <zsojka at seznam dot cz> ---
(In reply to Andrew Pinski from comment #3)
> I cannot reproduce it with r14-5450-g4db820928065ec or
> r14-5427-gd22b87864e5d47 .
Thank you for the investigation!
Either the flags have changed, or I did something very wrong; now it needs
-mbmi2 to fail:
(FAILs for me on r14-5443 , r14-5456 and r14-5476 )
$ md5sum testcase.c
5bc2d32fe8096769aca6bca7fb07470f testcase.c
$ x86_64-pc-linux-gnu-gcc -Os -mbmi2 testcase.c
$ ./a.out
Aborted
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug target/112518] [14 Regression] wrong code with __builtin_mul_overflow_p() and int128_t on x86_64-pc-linux-gnu
2023-11-13 19:34 [Bug target/112518] New: [14 Regression] wrong code with __builtin_mul_overflow_p() on x86_64-pc-linux-gnu zsojka at seznam dot cz
` (3 preceding siblings ...)
2023-11-15 3:48 ` zsojka at seznam dot cz
@ 2023-11-18 6:23 ` pinskia at gcc dot gnu.org
2023-11-21 18:51 ` jakub at gcc dot gnu.org
` (5 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: pinskia at gcc dot gnu.org @ 2023-11-18 6:23 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112518
--- Comment #5 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Works for me with r14-5566-g841008d3966c0f .
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug target/112518] [14 Regression] wrong code with __builtin_mul_overflow_p() and int128_t on x86_64-pc-linux-gnu
2023-11-13 19:34 [Bug target/112518] New: [14 Regression] wrong code with __builtin_mul_overflow_p() on x86_64-pc-linux-gnu zsojka at seznam dot cz
` (4 preceding siblings ...)
2023-11-18 6:23 ` pinskia at gcc dot gnu.org
@ 2023-11-21 18:51 ` jakub at gcc dot gnu.org
2023-11-21 19:00 ` sjames at gcc dot gnu.org
` (4 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: jakub at gcc dot gnu.org @ 2023-11-21 18:51 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112518
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords|needs-bisection |
CC| |jakub at gcc dot gnu.org
--- Comment #6 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
With -Os -mbmi2, it started for me with
r14-4968-g89e5d902fc55ad375f149f25a84c516ad360a606
and got fixed with
r14-5519-gf158bd511df1f55ebbbc0df3dee52c4400291984
So I'll just add it to the testsuite and we can close as dup of PR112526.
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug target/112518] [14 Regression] wrong code with __builtin_mul_overflow_p() and int128_t on x86_64-pc-linux-gnu
2023-11-13 19:34 [Bug target/112518] New: [14 Regression] wrong code with __builtin_mul_overflow_p() on x86_64-pc-linux-gnu zsojka at seznam dot cz
` (5 preceding siblings ...)
2023-11-21 18:51 ` jakub at gcc dot gnu.org
@ 2023-11-21 19:00 ` sjames at gcc dot gnu.org
2023-11-21 19:05 ` jakub at gcc dot gnu.org
` (3 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: sjames at gcc dot gnu.org @ 2023-11-21 19:00 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112518
--- Comment #7 from Sam James <sjames at gcc dot gnu.org> ---
We can add the test case at
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112526#c14 too if it's fine.
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug target/112518] [14 Regression] wrong code with __builtin_mul_overflow_p() and int128_t on x86_64-pc-linux-gnu
2023-11-13 19:34 [Bug target/112518] New: [14 Regression] wrong code with __builtin_mul_overflow_p() on x86_64-pc-linux-gnu zsojka at seznam dot cz
` (6 preceding siblings ...)
2023-11-21 19:00 ` sjames at gcc dot gnu.org
@ 2023-11-21 19:05 ` jakub at gcc dot gnu.org
2023-11-21 19:23 ` sjames at gcc dot gnu.org
` (2 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: jakub at gcc dot gnu.org @ 2023-11-21 19:05 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112518
--- Comment #8 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
That one seems to be too large IMHO.
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug target/112518] [14 Regression] wrong code with __builtin_mul_overflow_p() and int128_t on x86_64-pc-linux-gnu
2023-11-13 19:34 [Bug target/112518] New: [14 Regression] wrong code with __builtin_mul_overflow_p() on x86_64-pc-linux-gnu zsojka at seznam dot cz
` (7 preceding siblings ...)
2023-11-21 19:05 ` jakub at gcc dot gnu.org
@ 2023-11-21 19:23 ` sjames at gcc dot gnu.org
2023-11-22 10:33 ` cvs-commit at gcc dot gnu.org
2023-11-22 10:34 ` jakub at gcc dot gnu.org
10 siblings, 0 replies; 12+ messages in thread
From: sjames at gcc dot gnu.org @ 2023-11-21 19:23 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112518
--- Comment #9 from Sam James <sjames at gcc dot gnu.org> ---
ack, np.
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug target/112518] [14 Regression] wrong code with __builtin_mul_overflow_p() and int128_t on x86_64-pc-linux-gnu
2023-11-13 19:34 [Bug target/112518] New: [14 Regression] wrong code with __builtin_mul_overflow_p() on x86_64-pc-linux-gnu zsojka at seznam dot cz
` (8 preceding siblings ...)
2023-11-21 19:23 ` sjames at gcc dot gnu.org
@ 2023-11-22 10:33 ` cvs-commit at gcc dot gnu.org
2023-11-22 10:34 ` jakub at gcc dot gnu.org
10 siblings, 0 replies; 12+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2023-11-22 10:33 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112518
--- Comment #10 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:
https://gcc.gnu.org/g:8c24011b2ba0f268e74b72519fc8119c2c99d92b
commit r14-5752-g8c24011b2ba0f268e74b72519fc8119c2c99d92b
Author: Jakub Jelinek <jakub@redhat.com>
Date: Wed Nov 22 11:31:12 2023 +0100
testsuite: Add testcase for already fixed PR112518
This PR has been fixed by the PR112526 fix.
2023-11-22 Jakub Jelinek <jakub@redhat.com>
PR target/112518
* gcc.target/i386/bmi2-pr112518.c: New test.
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug target/112518] [14 Regression] wrong code with __builtin_mul_overflow_p() and int128_t on x86_64-pc-linux-gnu
2023-11-13 19:34 [Bug target/112518] New: [14 Regression] wrong code with __builtin_mul_overflow_p() on x86_64-pc-linux-gnu zsojka at seznam dot cz
` (9 preceding siblings ...)
2023-11-22 10:33 ` cvs-commit at gcc dot gnu.org
@ 2023-11-22 10:34 ` jakub at gcc dot gnu.org
10 siblings, 0 replies; 12+ messages in thread
From: jakub at gcc dot gnu.org @ 2023-11-22 10:34 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112518
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |DUPLICATE
Status|UNCONFIRMED |RESOLVED
--- Comment #11 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Dup.
*** This bug has been marked as a duplicate of bug 112526 ***
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2023-11-22 10:34 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-13 19:34 [Bug target/112518] New: [14 Regression] wrong code with __builtin_mul_overflow_p() on x86_64-pc-linux-gnu zsojka at seznam dot cz
2023-11-13 19:44 ` [Bug target/112518] " pinskia at gcc dot gnu.org
2023-11-13 19:45 ` [Bug target/112518] [14 Regression] wrong code with __builtin_mul_overflow_p() and int128_t " pinskia at gcc dot gnu.org
2023-11-14 23:36 ` pinskia at gcc dot gnu.org
2023-11-15 3:48 ` zsojka at seznam dot cz
2023-11-18 6:23 ` pinskia at gcc dot gnu.org
2023-11-21 18:51 ` jakub at gcc dot gnu.org
2023-11-21 19:00 ` sjames at gcc dot gnu.org
2023-11-21 19:05 ` jakub at gcc dot gnu.org
2023-11-21 19:23 ` sjames at gcc dot gnu.org
2023-11-22 10:33 ` cvs-commit at gcc dot gnu.org
2023-11-22 10:34 ` jakub at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).