public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug sanitizer/112563] [14 regression] libsanitizer doesn't assemble with Solaris/sparc as
Date: Mon, 20 Nov 2023 09:28:03 +0000	[thread overview]
Message-ID: <bug-112563-4-c7ydzc724j@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-112563-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112563

--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Note, following patch
--- libsanitizer/sanitizer_common/sanitizer_redefine_builtins.h.jj     
2023-11-15 17:19:11.512783752 +0100
+++ libsanitizer/sanitizer_common/sanitizer_redefine_builtins.h 2023-11-19
22:52:14.659301189 +0100
@@ -17,9 +17,24 @@
 // The asm hack only works with GCC and Clang.
 #    if !defined(_WIN32)

+#      if !defined(__GNUC__) || defined(__clang__)
 asm("memcpy = __sanitizer_internal_memcpy");
 asm("memmove = __sanitizer_internal_memmove");
 asm("memset = __sanitizer_internal_memset");
+#      else
+#        if defined(__cplusplus)
+extern "C" {
+#        endif
+extern void *(memcpy) (void *, const void *, __SIZE_TYPE__) __asm
("__sanitizer_internal_memcpy");
+extern void *(memmove) (void *, const void *, __SIZE_TYPE__) __asm
("__sanitizer_internal_memmove");
+extern void *(memset) (void *, int, __SIZE_TYPE__) __asm
("__sanitizer_internal_memset");
+extern void *__builtin_memcpy (void *, const void *, __SIZE_TYPE__) __asm
("__sanitizer_internal_memcpy");
+extern void *__builtin_memmove (void *, const void *, __SIZE_TYPE__) __asm
("__sanitizer_internal_memmove");
+extern void *__builtin_memset (void *, int, __SIZE_TYPE__) __asm
("__sanitizer_internal_memset");
+#        if defined(__cplusplus)
+}
+#        endif
+#      endif

 #      if defined(__cplusplus) && \
           !defined(SANITIZER_COMMON_REDEFINE_BUILTINS_IN_STD)

passed bootstrap/regtest for me on x86_64-linux and i686-linux and didn't
create any new memset/memcpy/memmove calls in objdump -dr libasan.so.* (we have
2 memset calls
from inside of libbacktrace, guess we ought to deal with that eventually).
Does this help on Solaris/sparc?

  parent reply	other threads:[~2023-11-20  9:28 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-16 10:20 [Bug sanitizer/112563] New: " ro at gcc dot gnu.org
2023-11-16 10:20 ` [Bug sanitizer/112563] " ro at gcc dot gnu.org
2023-11-16 12:47 ` rguenth at gcc dot gnu.org
2023-11-19 21:16 ` jakub at gcc dot gnu.org
2023-11-20  9:28 ` jakub at gcc dot gnu.org [this message]
2023-11-20 13:42 ` ro at CeBiTec dot Uni-Bielefeld.DE
2023-11-20 15:47 ` jakub at gcc dot gnu.org
2023-11-20 19:29 ` jakub at gcc dot gnu.org
2023-11-20 19:38 ` jakub at gcc dot gnu.org
2023-11-20 20:09 ` jakub at gcc dot gnu.org
2023-11-21 17:31 ` jakub at gcc dot gnu.org
2023-11-22 13:22 ` ro at CeBiTec dot Uni-Bielefeld.DE
2023-11-22 13:29 ` jakub at gcc dot gnu.org
2023-11-22 13:37 ` ro at CeBiTec dot Uni-Bielefeld.DE
2023-11-27 10:41 ` ro at CeBiTec dot Uni-Bielefeld.DE
2023-11-27 12:57 ` ro at gcc dot gnu.org
2023-11-28 13:54 ` cvs-commit at gcc dot gnu.org
2023-11-28 13:56 ` cvs-commit at gcc dot gnu.org
2023-11-28 15:07 ` ro at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-112563-4-c7ydzc724j@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).