public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug target/112606] [14 Regression] powerpc64le-linux-gnu: 'FAIL: gcc.target/powerpc/p8vector-fp.c scan-assembler xsnabsdp' Date: Tue, 05 Dec 2023 20:40:23 +0000 [thread overview] Message-ID: <bug-112606-4-RVG03rnZpt@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-112606-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112606 --- Comment #4 from GCC Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>: https://gcc.gnu.org/g:58d5546af901364f85588fe668559d76f09e6df9 commit r14-6192-g58d5546af901364f85588fe668559d76f09e6df9 Author: Jakub Jelinek <jakub@redhat.com> Date: Tue Dec 5 21:39:31 2023 +0100 rs6000: Canonicalize copysign (x, -1) back to -abs (x) in the backend [PR112606] The middle-end has been changed quite recently to canonicalize -abs (x) to copysign (x, -1) rather than the other way around. While I agree with that at GIMPLE level, since it matches the GIMPLE goal of as few operations as possible for a canonical form (-abs (x) is 2 GIMPLE statements, copysign (x, -1) is just one), I must say I don't really like that being done on RTL as well (or at least not canonicalizing (COPYSIGN x, negative) back to (NEG (ABS x))), because on most targets most of floating point constants need to be loaded from memory, there are a few exceptions but -1 is often not one of them. Anyway, the following patch fixes the rs6000 regression caused by the change in GIMPLE canonicalization (i.e. the desirable one). As rs6000 clearly prefers -abs (x) form because it has a single instruction to do that while it also has copysign instruction, but that requires loading the -1 from memory, the following patch just ensures the copysign expander can actually see the floating point constant and in that case emits the -abs (x) code (or in the hypothetical case of copysign with non-negative constant abs (x) - but there copysign (x, 1) in GIMPLE is canonicalized to abs (x)), otherwise forces the operand to be the expected gpc_reg_operand and does what it did before. 2023-12-05 Jakub Jelinek <jakub@redhat.com> PR target/112606 * config/rs6000/rs6000.md (copysign<mode>3): Change predicate of the last argument from gpc_reg_operand to any_operand. If operands[2] is CONST_DOUBLE, emit abs or neg abs depending on its sign, otherwise if it doesn't satisfy gpc_reg_operand, force it to REG using copy_to_mode_reg.
next prev parent reply other threads:[~2023-12-05 20:40 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-11-18 13:32 [Bug rtl-optimization/112606] New: " tschwinge at gcc dot gnu.org 2023-11-18 14:05 ` [Bug rtl-optimization/112606] " tnfchris at gcc dot gnu.org 2023-11-18 19:45 ` [Bug target/112606] " pinskia at gcc dot gnu.org 2023-11-24 17:59 ` jakub at gcc dot gnu.org 2023-11-28 19:43 ` seurer at gcc dot gnu.org 2023-12-05 20:40 ` cvs-commit at gcc dot gnu.org [this message] 2024-01-08 3:34 ` linkw at gcc dot gnu.org 2024-01-10 5:09 ` cvs-commit at gcc dot gnu.org 2024-01-10 5:20 ` linkw at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-112606-4-RVG03rnZpt@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).