public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug c++/112619] [14 regression] ICE when building libcrafter (tree check: expected statement_list, have modify_expr in tsi_start, at tree-iterator.h:57) since r14-5086-gae07265381d934 Date: Fri, 24 Nov 2023 07:54:17 +0000 [thread overview] Message-ID: <bug-112619-4-9XB91YeH5a@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-112619-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112619 --- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>: https://gcc.gnu.org/g:1c44bd92a86db3fcdeb4a66ce2f3222d13af0681 commit r14-5814-g1c44bd92a86db3fcdeb4a66ce2f3222d13af0681 Author: Jakub Jelinek <jakub@redhat.com> Date: Fri Nov 24 08:44:28 2023 +0100 tree: Fix up try_catch_may_fallthru [PR112619] The following testcase ICEs with -std=c++98 since r14-5086 because block_may_fallthru is called on a TRY_CATCH_EXPR whose second operand is a MODIFY_EXPR rather than STATEMENT_LIST, which try_catch_may_fallthru apparently expects. I've been wondering whether that isn't some kind of FE bug and whether there isn't some unwritten rule that second operand of TRY_CATCH_EXPR must be a STATEMENT_LIST. Looking at the FEs, the C++ FE uses mostly its own trees, TRY_BLOCK (TRY_CATCH_EXPR replacement) with HANDLER in it (CATCH_EXPR replacement) - but HANDLER can be immediate second operand rather than nested in STATEMENT_LIST, EH_SPEC_BLOCK (this one stands for both TRY_CATCH_EXPR and EH_FILTER_EXPR in its second argument); both of these are only replaced by the generic trees during gimplification though, so will unlikely be seen by block_may_fallthru; and then CLEANUP_STMT, which is genericized into TRY_CATCH_EXPR with non-CATCH_EXPR/EH_FILTER_EXPR in its body (this is the one that causes the ICE on this testcase). The Go and Rust FEs create TRY_CATCH_EXPR with CATCH_EXPR immediately in its second argument (but either are unlucky that block_may_fallthru isn't called or the body can always fallthru, or latent ICE), while the D FE most likely hit this ICE and attempts to work around it, by checking at TRY_CATCH_EXPR creation time if the second argument from pop_stmt_list is STATEMENT_LIST and if not, forcefully wraps it into a STATEMENT_LIST. Unfortunately, I don't see an easy way to create an artificial tree iterator from just a single tree statement, so the patch duplicates what the loops later do (after all, it is very simple, just didn't want to duplicate also the large comments explaning it, so the 3 See below. comments). 2023-11-24 Jakub Jelinek <jakub@redhat.com> PR c++/112619 * tree.cc (try_catch_may_fallthru): If second operand of TRY_CATCH_EXPR is not a STATEMENT_LIST, handle it as if it was a STATEMENT_LIST containing a single statement. * g++.dg/eh/pr112619.C: New test.
next prev parent reply other threads:[~2023-11-24 7:54 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-11-19 13:53 [Bug middle-end/112619] New: [14 regression] ICE when building libcrafter (tree check: expected statement_list, have modify_expr in tsi_start, at tree-iterator.h:57) sjames at gcc dot gnu.org 2023-11-19 14:57 ` [Bug middle-end/112619] " kocelfc at tutanota dot com 2023-11-19 16:48 ` kocelfc at tutanota dot com 2023-11-19 19:30 ` [Bug c++/112619] [14 regression] ICE when building libcrafter (tree check: expected statement_list, have modify_expr in tsi_start, at tree-iterator.h:57) since r14-5086-gae07265381d934 pinskia at gcc dot gnu.org 2023-11-19 19:35 ` pinskia at gcc dot gnu.org 2023-11-20 10:18 ` rguenth at gcc dot gnu.org 2023-11-21 18:01 ` jakub at gcc dot gnu.org 2023-11-21 18:25 ` jakub at gcc dot gnu.org 2023-11-24 7:54 ` cvs-commit at gcc dot gnu.org [this message] 2023-11-24 8:45 ` jakub at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-112619-4-9XB91YeH5a@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).