public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "fkastl at suse dot cz" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/112687] missed-optimization: switch statement does not simplify to it's expression Date: Fri, 26 Jan 2024 11:59:27 +0000 [thread overview] Message-ID: <bug-112687-4-nFdV5lqBkq@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-112687-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112687 --- Comment #2 from Filip Kastl <fkastl at suse dot cz> --- Created attachment 57222 --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=57222&action=edit WIP patch to fix the missed optimization, version 0 I'm working on a patch. The problem (as Richard stated in pr112645) is that the testcase gets optimized into switch (v & 3) { default: return 0; case 1: return 1; case 2: return 2; case 3: return 3; } so the information that there are only 4 possible values of the expression 'v & 3' is lost. I add capability for switch conversion to recover from this. With my patch, before processing the switch, switch conversion finds out if the default case only corresponds to one possible value of the index expression. If so, it creates a case for this value and marks default as unreachable. With the patch applied, functions opt() and unopt() compile into the same sequence of assembly instructions. I've attached the patch. Do you think this is a good approach? I'll also appreciate any suggestions/comments for the patch.
prev parent reply other threads:[~2024-01-26 11:59 UTC|newest] Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-11-23 21:43 [Bug tree-optimization/112687] New: " goon.pri.low at gmail dot com 2023-11-24 8:04 ` [Bug tree-optimization/112687] " rguenth at gcc dot gnu.org 2024-01-26 11:59 ` fkastl at suse dot cz [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-112687-4-nFdV5lqBkq@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).