public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug preprocessor/112701] wrong type inference for ternary operator with `0/0u` in preprocessing context Date: Tue, 28 Nov 2023 02:44:54 +0000 [thread overview] Message-ID: <bug-112701-4-jf7RjemZSc@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-112701-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112701 --- Comment #7 from GCC Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Lewis Hyatt <lhyatt@gcc.gnu.org>: https://gcc.gnu.org/g:ce52f1f7074d96c4d9ce63b1169c11087757e926 commit r14-5898-gce52f1f7074d96c4d9ce63b1169c11087757e926 Author: Lewis Hyatt <lhyatt@gmail.com> Date: Mon Nov 27 12:08:41 2023 -0500 libcpp: Fix unsigned promotion for unevaluated divide by zero [PR112701] When libcpp encounters a divide by zero while processing a constant expression "x/y", it returns "x" as a fallback. The value of the fallback is not normally important, since an error will be generated anyway, but if the expression appears in an unevaluated context, such as "0 ? 0/0u : -1", then there will be no error, and the fallback value will be meaningful to the extent that it may cause promotion from signed to unsigned of an operand encountered later. As the PR notes, libcpp does not do the unsigned promotion correctly in this case; fix it by making the fallback return value unsigned as necessary. libcpp/ChangeLog: PR preprocessor/112701 * expr.cc (num_div_op): Set unsignedp appropriately when returning a stub value for divide by 0. gcc/testsuite/ChangeLog: PR preprocessor/112701 * gcc.dg/cpp/expr.c: Add additional tests to cover divide by 0 in an unevaluated context, where the unsignedness still matters.
next prev parent reply other threads:[~2023-11-28 2:44 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-11-24 14:56 [Bug preprocessor/112701] New: wrong type inference for ternary operator " amonakov at gcc dot gnu.org 2023-11-24 15:46 ` [Bug preprocessor/112701] wrong type inference for ternary operator with `0/0u` " pinskia at gcc dot gnu.org 2023-11-25 17:06 ` mikpelinux at gmail dot com 2023-11-27 7:56 ` rguenth at gcc dot gnu.org 2023-11-27 17:56 ` lhyatt at gcc dot gnu.org 2023-11-27 18:02 ` pinskia at gcc dot gnu.org 2023-11-28 0:14 ` lhyatt at gcc dot gnu.org 2023-11-28 2:44 ` cvs-commit at gcc dot gnu.org [this message] 2023-11-28 2:45 ` lhyatt at gcc dot gnu.org 2023-11-28 6:54 ` sjames at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-112701-4-jf7RjemZSc@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).