From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 101EE3858412; Mon, 27 Nov 2023 12:46:55 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 101EE3858412 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1701089216; bh=QL+saxEeX4hjOVQb0q3bARyfuRYHHC5uJnnW25GAVG4=; h=From:To:Subject:Date:In-Reply-To:References:From; b=hBzjdMY8KzgbGSWNfgwgRJOu+9g4kfE7Kjo60OExuJ2w2wQmwRdOUdgGMWgr0fUNO rBYeqQReiCIUjPGF5zvNQe4vsfU83eUFXDkYXI8BBSoQpPZlX4QpdkFnq7eqlems06 DxM6ByYqPhZgYW0MIIL6EU8G3GmBT/7fFZftY8Is= From: "jakub at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug sanitizer/112709] [13/14 Regression] address sanitize and returns_twice causes an ICE Date: Mon, 27 Nov 2023 12:46:55 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: sanitizer X-Bugzilla-Version: 14.0 X-Bugzilla-Keywords: ice-checking, ice-on-valid-code X-Bugzilla-Severity: normal X-Bugzilla-Who: jakub at gcc dot gnu.org X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: 13.3 X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 List-Id: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D112709 --- Comment #2 from Jakub Jelinek --- This isn't specific to asan, -fsanitize=3Dundefined ICEs on it the same. In both cases, we want to add instrumentation for the store of the call lhs. So, either we move the instrumentation on the non-abnormal predecessor edge= of the calls, but then we actually don't perform the checking when reaching the call through the abnormal edge (i.e. returning for second and following time from the ca= ll, in the caller perhaps the pointer might have changed). Or we stop doing such instrumentations on the call lhs and instead do such instrumentation in the callee (on =3D whatever; stores).=