public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/112724] C++ "'excess_precision_expr' not supported by dump_expr<expression error>"
Date: Tue, 26 Mar 2024 09:04:49 +0000	[thread overview]
Message-ID: <bug-112724-4-qukaq2Z2kl@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-112724-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112724

--- Comment #4 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:10accfde57951db9f726e996f1b0be165df00f5c

commit r14-9663-g10accfde57951db9f726e996f1b0be165df00f5c
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Tue Mar 26 10:03:27 2024 +0100

    c-family, c++: Handle EXCESS_PRECISION_EXPR in pretty printers [PR112724]

    I've noticed that the c-c++-common/gomp/depobj-3.c test FAILs on
i686-linux:
    PASS: c-c++-common/gomp/depobj-3.c  -std=c++17  at line 17 (test for
warnings, line 15)
    FAIL: c-c++-common/gomp/depobj-3.c  -std=c++17  at line 39 (test for
warnings, line 37)
    PASS: c-c++-common/gomp/depobj-3.c  -std=c++17  at line 43 (test for
errors, line 41)
    PASS: c-c++-common/gomp/depobj-3.c  -std=c++17  (test for warnings, line
45)
    FAIL: c-c++-common/gomp/depobj-3.c  -std=c++17 (test for excess errors)
    Excess errors:
    /home/jakub/src/gcc/gcc/testsuite/c-c++-common/gomp/depobj-3.c:37:38:
warning: the 'destroy' expression ''excess_precision_expr' not supported by
dump_expr<expression error>' should
    +be the same as the 'depobj' argument 'obj' [-Wopenmp]
    The following patch replaces that 'excess_precision_expr' not supported by
dump_expr<expression error>
    with (float)(((long double)a) + (long double)5)
    Still ugly and doesn't actually fix the FAIL (will deal with that
    incrementally), but at least valid C/C++ and shows the excess precision
    handling in action.

    2024-03-26  Jakub Jelinek  <jakub@redhat.com>

            PR c++/112724
    gcc/c-family/
            * c-pretty-print.cc (pp_c_cast_expression,
            c_pretty_printer::expression): Handle EXCESS_PRECISION_EXPR like
            NOP_EXPR.
    gcc/cp/
            * error.cc (dump_expr): Handle EXCESS_PRECISION_EXPR like NOP_EXPR.

  parent reply	other threads:[~2024-03-26  9:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-27  9:52 [Bug c++/112724] New: " tschwinge at gcc dot gnu.org
2023-11-27  9:53 ` [Bug c++/112724] " tschwinge at gcc dot gnu.org
2023-11-27 10:01 ` rguenth at gcc dot gnu.org
2024-03-22  9:26 ` cvs-commit at gcc dot gnu.org
2024-03-26  9:04 ` cvs-commit at gcc dot gnu.org [this message]
2024-03-26  9:11 ` jakub at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-112724-4-qukaq2Z2kl@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).