public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "linkw at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/112725] [14 Regression] powerpc64le-linux-gnu: 'c-c++-common/builtin-classify-type-1.c:113:3: error: AltiVec argument passed to unprototyped function'
Date: Wed, 29 Nov 2023 08:50:44 +0000	[thread overview]
Message-ID: <bug-112725-4-D0QAtoD2jc@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-112725-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112725

--- Comment #4 from Kewen Lin <linkw at gcc dot gnu.org> ---
(In reply to Jakub Jelinek from comment #3)
> Agreed, so like this?

Yes, thanks for the prompt fix!  The rs6000 part is OK for trunk!

> 2023-11-29  Jakub Jelinek  <jakub@redhat.com>
> 
> 	PR target/112725
> 	* config/rs6000/rs6000.cc (invalid_arg_for_unprototyped_fn): Return
> 	NULL for __builtin_classify_type calls with vector arguments.
> 	* config/s390/s390.cc (s390_invalid_arg_for_unprototyped_fn):
> 	Likewise.
> 
> --- gcc/config/rs6000/rs6000.cc.jj	2023-11-17 15:08:20.816961466 +0100
> +++ gcc/config/rs6000/rs6000.cc	2023-11-29 09:40:35.782955603 +0100
> @@ -24389,7 +24389,8 @@ invalid_arg_for_unprototyped_fn (const_t
>  	  && VECTOR_TYPE_P (TREE_TYPE (val))
>            && (funcdecl == NULL_TREE
>                || (TREE_CODE (funcdecl) == FUNCTION_DECL
> -                  && DECL_BUILT_IN_CLASS (funcdecl) != BUILT_IN_MD)))
> +                  && DECL_BUILT_IN_CLASS (funcdecl) != BUILT_IN_MD
> +                  && !fndecl_built_in_p (funcdecl,
> BUILT_IN_CLASSIFY_TYPE))))
>  	  ? N_("AltiVec argument passed to unprototyped function")
>  	  : NULL;
>  }
> --- gcc/config/s390/s390.cc.jj	2023-11-27 17:34:25.684287136 +0100
> +++ gcc/config/s390/s390.cc	2023-11-29 09:41:08.569491077 +0100
> @@ -12650,7 +12650,8 @@ s390_invalid_arg_for_unprototyped_fn (co
>  	   && VECTOR_TYPE_P (TREE_TYPE (val))
>  	   && (funcdecl == NULL_TREE
>  	       || (TREE_CODE (funcdecl) == FUNCTION_DECL
> -		   && DECL_BUILT_IN_CLASS (funcdecl) != BUILT_IN_MD)))
> +		   && DECL_BUILT_IN_CLASS (funcdecl) != BUILT_IN_MD
> +		   && !fndecl_built_in_p (funcdecl, BUILT_IN_CLASSIFY_TYPE))))
>  	  ? N_("vector argument passed to unprototyped function")
>  	  : NULL);
>  }

  parent reply	other threads:[~2023-11-29  8:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-27 10:23 [Bug target/112725] New: " tschwinge at gcc dot gnu.org
2023-11-27 14:39 ` [Bug target/112725] " rguenth at gcc dot gnu.org
2023-11-27 18:31 ` pinskia at gcc dot gnu.org
2023-11-29  8:32 ` linkw at gcc dot gnu.org
2023-11-29  8:43 ` jakub at gcc dot gnu.org
2023-11-29  8:50 ` linkw at gcc dot gnu.org [this message]
2023-11-29 18:21 ` cvs-commit at gcc dot gnu.org
2023-12-01  7:15 ` cvs-commit at gcc dot gnu.org
2023-12-01  7:16 ` jakub at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-112725-4-D0QAtoD2jc@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).