From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 3C5753858C50; Tue, 28 Nov 2023 12:11:50 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3C5753858C50 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1701173510; bh=qJmgVYaUk8n1NxRdOjj0MYCQ6ifdoWDX2Z4tf+1D1Nk=; h=From:To:Subject:Date:In-Reply-To:References:From; b=Swn6ciipf55PdR9b4SgO0BSgjd9vImPHDJQlrDPwIelms0rjdc2m5haWcRS1Kskgc DMf+H0cEe8Gt1QOjc38wlQZlFCoiFLq/MEhHXaQyzzJPljIxs/obPZidA895m2O3mW jF9onig34yw636Dad56wDdt9cTKps8P/MSH/58II= From: "ro at CeBiTec dot Uni-Bielefeld.DE" To: gcc-bugs@gcc.gnu.org Subject: [Bug testsuite/112729] gcc.target/i386/apx-interrupt-1.c etc. FAIL Date: Tue, 28 Nov 2023 12:11:49 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: testsuite X-Bugzilla-Version: 14.0 X-Bugzilla-Keywords: testsuite-fail X-Bugzilla-Severity: normal X-Bugzilla-Who: ro at CeBiTec dot Uni-Bielefeld.DE X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: 14.0 X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 List-Id: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D112729 --- Comment #5 from ro at CeBiTec dot Uni-Bielefeld.DE --- > --- Comment #3 from Hongyu Wang --- [...] > Hi Rainer, can you help verify if the change make these test pass on > solaris/FreeBSD? They do on Solaris/x86. Thanks. FreeBSD was more involved (I'd only noticed the failure there on gcc-testresults). Unfortunately, there's no FreeBSD/x86_64 system in the cfarm. However, I had an old FreeBSD 13 VM around which could be coaxed into a gcc build with some effort. With your patch, the failures are gone there, too. One nit: diff --git a/gcc/testsuite/gcc.target/i386/apx-push2pop2-1.c b/gcc/testsuite/gcc.target/i386/apx-push2pop2-1.c index d78c96d36a3..1d73aab1128 100644 --- a/gcc/testsuite/gcc.target/i386/apx-push2pop2-1.c +++ b/gcc/testsuite/gcc.target/i386/apx-push2pop2-1.c @@ -1,5 +1,5 @@ /* { dg-do compile { target { ! ia32 } } } */ -/* { dg-options "-O2 -mapx-features=3Dpush2pop2" } */ +/* { dg-options "-O2 -fomit-frame-pointer -mapx-features=3Dpush2pop2" } */ /* { dg-skip-if "does not emit .cfi_xxx" "*-*-darwin*" } */ extern int bar (int); diff --git a/gcc/testsuite/gcc.target/i386/apx-push2pop2_force_drap-1.c b/gcc/testsuite/gcc.target/i386/apx-push2pop2_force_drap-1.c index 3cac7b10769..4e2259f0c99 100644 --- a/gcc/testsuite/gcc.target/i386/apx-push2pop2_force_drap-1.c +++ b/gcc/testsuite/gcc.target/i386/apx-push2pop2_force_drap-1.c @@ -1,5 +1,5 @@ /* { dg-do compile { target { ! ia32 } } } */ -/* { dg-options "-O2 -mapx-features=3Dpush2pop2 -mforce-drap" } */ +/* { dg-options "-O2 -mapx-features=3Dpush2pop2 -fomit-frame-pointer -mforce-drap" } */ /* { dg-skip-if "does not emit .cfi_xxx" "*-*-darwin*" } */ #include "apx-push2pop2-1.c" Is there a reason to have -fomit-frame-pointer once before and once after -mapx-features=3Dpush2pop2?=