public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug middle-end/112733] [14 Regression] ICE: Segmentation fault in wide-int.cc during GIMPLE pass: sccp Date: Tue, 28 Nov 2023 17:43:00 +0000 [thread overview] Message-ID: <bug-112733-4-QdzhgDBMhM@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-112733-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112733 --- Comment #11 from Jakub Jelinek <jakub at gcc dot gnu.org> --- Created attachment 56707 --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=56707&action=edit gcc14-pr112733-2.patch Second patch to be tested. Turned out it is more complicated than that. If n > m, i.e. when divisor in absolute value is larger than dividend, we want divmod_internal_2 to know that, such that e.g. it skips the main loop and looks at correct most significant half limb of the divisor, but the if (s) for (i = 0; i < n; i++) b_remainder[i] = (b_dividend[i] >> s) | (b_dividend[i+1] << (HOST_BITS_PER_HALF_WIDE_INT - s)); else for (i = 0; i < n; i++) b_remainder[i] = b_dividend[i]; loops in such case already may invoke UB, because they copy stuff from b_dividend which just isn't there, at best some random upper bits, at worst crash. We can't copy more than there is in the array and need to tell the caller how much we've initialized, so that wi_pack can take it into account. While looking into this, I've noticed that I've allocated in case of XALLOCAVEC multiplication and division/remainder calculations twice or 4 times as much as really needed, so this patch fixes that too.
next prev parent reply other threads:[~2023-11-28 17:43 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-11-27 19:12 [Bug middle-end/112733] New: " patrick at rivosinc dot com 2023-11-27 19:16 ` [Bug middle-end/112733] " pinskia at gcc dot gnu.org 2023-11-27 19:16 ` pinskia at gcc dot gnu.org 2023-11-27 19:21 ` pinskia at gcc dot gnu.org 2023-11-27 19:25 ` pinskia at gcc dot gnu.org 2023-11-28 9:02 ` rguenth at gcc dot gnu.org 2023-11-28 9:35 ` jakub at gcc dot gnu.org 2023-11-28 14:34 ` jakub at gcc dot gnu.org 2023-11-28 14:48 ` jakub at gcc dot gnu.org 2023-11-28 15:56 ` jakub at gcc dot gnu.org 2023-11-28 16:01 ` jakub at gcc dot gnu.org 2023-11-28 17:37 ` jakub at gcc dot gnu.org 2023-11-28 17:43 ` jakub at gcc dot gnu.org [this message] 2023-11-29 9:29 ` jakub at gcc dot gnu.org 2023-11-29 11:27 ` cvs-commit at gcc dot gnu.org 2023-11-30 8:15 ` cvs-commit at gcc dot gnu.org 2023-11-30 8:16 ` jakub at gcc dot gnu.org 2023-12-15 14:05 ` cvs-commit at gcc dot gnu.org 2023-12-16 0:38 ` cvs-commit at gcc dot gnu.org 2023-12-17 13:55 ` cvs-commit at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-112733-4-QdzhgDBMhM@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).