public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/112736] [14 Regression] vectorizer is introducing out of bounds memory access
Date: Tue, 28 Nov 2023 12:10:06 +0000	[thread overview]
Message-ID: <bug-112736-4-uAtoqdLJl6@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-112736-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112736

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |rguenth at gcc dot gnu.org

--- Comment #2 from Richard Biener <rguenth at gcc dot gnu.org> ---
The vectorizer sees

  <bb 3> [local count: 214748368]:
  # a.3_5 = PHI <_2(5), 2(2)>
  # ivtmp_9 = PHI <ivtmp_3(5), 3(2)>
  _14 = b[a.3_5];
  c[a.3_5][0] = _14;
  c[a.3_5][1] = _14;
  c[a.3_5][2] = _14;
  c[a.3_5][3] = _14;
  _2 = a.3_5 + -1;
  ivtmp_3 = ivtmp_9 - 1;
  if (ivtmp_3 != 0)
    goto <bb 5>; [89.00%]
  else
    goto <bb 4>; [11.00%]

  <bb 5> [local count: 191126048]:
  goto <bb 3>; [100.00%]

and uses SLP, this is likely caused by my patch to allow non-grouped-loads
there.

t.c:7:17: note:   node 0x4637048 (max_nunits=4, refcnt=1) vector(4) int
t.c:7:17: note:   op template: _14 = b[a.3_5];
t.c:7:17: note:         stmt 0 _14 = b[a.3_5];
t.c:7:17: note:         stmt 1 _14 = b[a.3_5];
t.c:7:17: note:         stmt 2 _14 = b[a.3_5];
t.c:7:17: note:         stmt 3 _14 = b[a.3_5];
t.c:7:17: note:         load permutation { 0 0 0 0 }

I think we need to force strided-SLP for them.

  parent reply	other threads:[~2023-11-28 12:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-27 22:30 [Bug tree-optimization/112736] New: " kristerw at gcc dot gnu.org
2023-11-27 22:44 ` [Bug tree-optimization/112736] [14 Regression] " pinskia at gcc dot gnu.org
2023-11-28 12:10 ` rguenth at gcc dot gnu.org [this message]
2023-12-11 13:43 ` rguenth at gcc dot gnu.org
2023-12-12 14:26 ` cvs-commit at gcc dot gnu.org
2023-12-12 14:27 ` rguenth at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-112736-4-uAtoqdLJl6@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).