public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "pinskia at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/112752] New: `~a - MIN<MIN<~a, ~b>, ~c>` is not optimized to `MAX<MAX<a,b>,c> - a` Date: Tue, 28 Nov 2023 22:32:01 +0000 [thread overview] Message-ID: <bug-112752-4@http.gcc.gnu.org/bugzilla/> (raw) https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112752 Bug ID: 112752 Summary: `~a - MIN<MIN<~a, ~b>, ~c>` is not optimized to `MAX<MAX<a,b>,c> - a` Product: gcc Version: 14.0 Status: UNCONFIRMED Keywords: missed-optimization Severity: enhancement Priority: P3 Component: tree-optimization Assignee: unassigned at gcc dot gnu.org Reporter: pinskia at gcc dot gnu.org CC: evstupac at gmail dot com, kirill.yukhin at intel dot com, pinskia at gcc dot gnu.org, rguenth at gcc dot gnu.org, unassigned at gcc dot gnu.org Target Milestone: --- Target: x86_64-*-* +++ This bug was initially created as a clone of Bug #52252 +++ This is an example of byte conversion from RGB (Red Green Blue) to CMYK (Cyan Magenta Yellow blacK): ``` #define byte unsigned char #define MIN(a, b) ((a) > (b)?(b):(a)) void convert_image(byte *in, byte *out, int size) { int i; for(i = 0; i < size; i++) { byte r = in[0]; byte g = in[1]; byte b = in[2]; byte c, m, y, k, tmp; c = 255 - r; m = 255 - g; y = 255 - b; tmp = MIN(m, y); k = MIN(c, tmp); out[0] = c - k; out[1] = m - k; out[2] = y - k; out[3] = k; in += 3; out += 4; } } ``` For the scalar (and vectorized versions) we should get instead: ``` #define byte unsigned char #define MIN(a, b) ((a) > (b)?(b):(a)) #define MAX(a, b) ((a) < (b)?(b):(a)) void convert_image_1(byte *in, byte *out, int size) { int i; for(i = 0; i < size; i++) { byte r = in[0]; byte g = in[1]; byte b = in[2]; byte c, m, y, k, tmp; tmp = MIN(r, g); k = MIN(b, tmp); out[0] = k - r; out[1] = k - g; out[2] = k - b; out[3] = 255 - k; in += 3; out += 4; } } ``` See bug 52252 comment #10, 11, and 12 also.
next reply other threads:[~2023-11-28 22:32 UTC|newest] Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-11-28 22:32 pinskia at gcc dot gnu.org [this message] 2023-11-28 22:32 ` [Bug tree-optimization/112752] " pinskia at gcc dot gnu.org 2023-11-28 23:01 ` pinskia at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-112752-4@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).