public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "pinskia at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug driver/112759] [13/14 regression] mips -march=native detection broken with gcc 13+
Date: Wed, 29 Nov 2023 22:16:30 +0000	[thread overview]
Message-ID: <bug-112759-4-rSF3srlRT9@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-112759-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112759

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[13 regression] mips        |[13/14 regression] mips
                   |-march=native detection     |-march=native detection
                   |broken with gcc 13+         |broken with gcc 13+

--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Hmm, looks like it is this part of the change:
+  if (cpu)
+    ret = reconcat (ret, ret, "-m", argv[0], "=", cpu, NULL);

-  return concat ("-m", argv[0], "=", cpu, NULL);


Maybe it should have been:
```
if (cpu)
  {
    if (!ret)
      ret = concat ("-m", argv[0], "=", cpu, NULL);
    else
      ret = reconcat (ret, ret, "-m", argv[0], "=", cpu, NULL);
  }
```

Can you try that?

  parent reply	other threads:[~2023-11-29 22:16 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-29  7:10 [Bug driver/112759] New: [13 " matoro_gcc_bugzilla at matoro dot tk
2023-11-29  7:10 ` [Bug driver/112759] " matoro_gcc_bugzilla at matoro dot tk
2023-11-29 22:16 ` pinskia at gcc dot gnu.org [this message]
2023-11-30  8:42 ` [Bug driver/112759] [13/14 " rguenth at gcc dot gnu.org
2023-11-30 15:37 ` matoro_gcc_bugzilla at matoro dot tk
2023-12-13  0:47 ` pinskia at gcc dot gnu.org
2023-12-18  2:24 ` [Bug driver/112759] [13/14 regression] mips -march=native detection broken with gcc 13+ since r13-3178-g66c48be23e0fa5 syq at gcc dot gnu.org
2023-12-18  3:16 ` syq at gcc dot gnu.org
2023-12-23  8:47 ` cvs-commit at gcc dot gnu.org
2023-12-23  8:51 ` cvs-commit at gcc dot gnu.org
2023-12-23  8:55 ` syq at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-112759-4-rSF3srlRT9@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).