From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 54F633857C56; Wed,  6 Dec 2023 08:59:58 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 54F633857C56
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1701853198;
	bh=kjLfB2Atpsgf5iBkTuUJ+YAWb0cwDT5ENYg6912Lrf0=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=Hb4I5Ctw7kOz8jo4Tj73ywiTTFQPvu/6NFzMta74RqP2n4xs0ZFqltLVspO+QQW/a
	 Hsy1mHga2Hh6s6baz+QIrLL0r7IyipWImyAP/av/J4yoQIQeBX0HWSajzlg4VNB4qy
	 gZmBKIIdVDK/mX6ZJVXtAt4xMweqeyrWK9LiHX+I=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug rtl-optimization/112760] [14 Regression] wrong code with -O2
 -fno-dce -fno-guess-branch-probability -m8bit-idiv -mavx
 --param=max-cse-insns=0 and __builtin_add_overflow_p() since r14-5355
Date: Wed, 06 Dec 2023 08:59:57 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: rtl-optimization
X-Bugzilla-Version: 14.0
X-Bugzilla-Keywords: wrong-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: jakub at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 14.0
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-112760-4-sTk8P7mnjS@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-112760-4@http.gcc.gnu.org/bugzilla/>
References: <bug-112760-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D112760

--- Comment #6 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:e44ed92dbbe9d4e5c23f486cd2f77a6f9ee513c5

commit r14-6210-ge44ed92dbbe9d4e5c23f486cd2f77a6f9ee513c5
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Wed Dec 6 09:59:12 2023 +0100

    i386: Move vzeroupper pass from after reload pass to after postreload_c=
se
[PR112760]

    Regardless of the outcome of the REG_UNUSED discussions, I think
    it is a good idea to move the vzeroupper pass one pass later.
    As can be seen in the multiple PRs and as postreload.cc documents,
    reload/LRA is known to create dead statements quite often, which
    is the reason why we have postreload_cse pass at all.
    Doing vzeroupper pass before such cleanup means the pass including
    df_analyze for it needs to process more instructions than needed
    and because mode switching adds note problem, also higher chance of
    having stale REG_UNUSED notes.
    And, I really don't see why vzeroupper can't wait until those cleanups
    are done.

    2023-12-06  Jakub Jelinek  <jakub@redhat.com>

            PR rtl-optimization/112760
            * config/i386/i386-passes.def (pass_insert_vzeroupper): Insert
            after pass_postreload_cse rather than pass_reload.
            * config/i386/i386-features.cc (rest_of_handle_insert_vzerouppe=
r):
            Adjust comment for it.

            * gcc.dg/pr112760.c: New test.=