public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "sebastian.huber@embedded-brains.de" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug target/112777] [14 Regression] profiled bootstrap fails on powerpc-linux-gnu, undefined references to __atomic_fetch_add_8 Date: Thu, 30 Nov 2023 13:44:30 +0000 [thread overview] Message-ID: <bug-112777-4-VgLA7iCV0D@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-112777-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112777 --- Comment #3 from Sebastian Huber <sebastian.huber@embedded-brains.de> --- I think the issue is in c-cppbuiltin.cc: builtin_define_with_int_value ("__LIBGCC_HAVE_LIBATOMIC", targetm.have_libatomic); Which is used in libgcov.h like this: /* Detect whether target can support atomic update of profilers. */ #if (__SIZEOF_LONG_LONG__ == 4 && __GCC_HAVE_SYNC_COMPARE_AND_SWAP_4) \ || (__SIZEOF_LONG_LONG__ == 8 && __GCC_HAVE_SYNC_COMPARE_AND_SWAP_8) \ || defined (__LIBGCC_HAVE_LIBATOMIC) #define GCOV_SUPPORTS_ATOMIC 1 #else #define GCOV_SUPPORTS_ATOMIC 0 #endif Should I keep the defined (__LIBGCC_HAVE_LIBATOMIC) and change c-cppbuiltin.cc to: if (targetm.have_libatomic) builtin_define ("__LIBGCC_HAVE_LIBATOMIC"); Or, should I change libgcov.h to use: #if (__SIZEOF_LONG_LONG__ == 4 && __GCC_HAVE_SYNC_COMPARE_AND_SWAP_4) \ || (__SIZEOF_LONG_LONG__ == 8 && __GCC_HAVE_SYNC_COMPARE_AND_SWAP_8) \ || __LIBGCC_HAVE_LIBATOMIC
next prev parent reply other threads:[~2023-11-30 13:44 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-11-30 10:52 [Bug target/112777] New: " doko at gcc dot gnu.org 2023-11-30 12:24 ` [Bug target/112777] " rguenth at gcc dot gnu.org 2023-11-30 12:37 ` doko at gcc dot gnu.org 2023-11-30 13:44 ` sebastian.huber@embedded-brains.de [this message] 2023-12-01 8:55 ` cvs-commit at gcc dot gnu.org 2023-12-01 11:59 ` jakub at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-112777-4-VgLA7iCV0D@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).