From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id B20AF3858C66; Thu, 30 Nov 2023 13:44:30 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B20AF3858C66
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1701351870;
	bh=+CMkvWoyWrEWj7UwhK3g/zXbIK4T+Ib3Ndga1wRA+NE=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=fDDZP+dyLTAVs0/VEfMO8VEbrJxYm/4pWuav+XH0Rqp4GvOeJv5epTDE89MDj86Mt
	 0v0jndYjvHH6nLRs5YnrttULg64SWvs0ywpx5uQCs9+N06G5/hG9qW6hAKprgBqIEM
	 xOOsDUIl7YDlEFrgLhBby+uaDS/e6lWYy4SdcUuE=
From: "sebastian.huber@embedded-brains.de" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/112777] [14 Regression] profiled bootstrap fails on
 powerpc-linux-gnu, undefined references to __atomic_fetch_add_8
Date: Thu, 30 Nov 2023 13:44:30 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 14.0
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: sebastian.huber@embedded-brains.de
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 14.0
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-112777-4-VgLA7iCV0D@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-112777-4@http.gcc.gnu.org/bugzilla/>
References: <bug-112777-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D112777

--- Comment #3 from Sebastian Huber <sebastian.huber@embedded-brains.de> ---
I think the issue is in c-cppbuiltin.cc:

      builtin_define_with_int_value ("__LIBGCC_HAVE_LIBATOMIC",
                                     targetm.have_libatomic);

Which is used in libgcov.h like this:

/* Detect whether target can support atomic update of profilers.  */
#if (__SIZEOF_LONG_LONG__ =3D=3D 4 && __GCC_HAVE_SYNC_COMPARE_AND_SWAP_4) \
    || (__SIZEOF_LONG_LONG__ =3D=3D 8 && __GCC_HAVE_SYNC_COMPARE_AND_SWAP_8=
) \
    || defined (__LIBGCC_HAVE_LIBATOMIC)
#define GCOV_SUPPORTS_ATOMIC 1
#else
#define GCOV_SUPPORTS_ATOMIC 0
#endif

Should I keep the defined (__LIBGCC_HAVE_LIBATOMIC) and change c-cppbuiltin=
.cc
to:

if (targetm.have_libatomic)
  builtin_define ("__LIBGCC_HAVE_LIBATOMIC");

Or, should I change libgcov.h to use:

#if (__SIZEOF_LONG_LONG__ =3D=3D 4 && __GCC_HAVE_SYNC_COMPARE_AND_SWAP_4) \
    || (__SIZEOF_LONG_LONG__ =3D=3D 8 && __GCC_HAVE_SYNC_COMPARE_AND_SWAP_8=
) \
    || __LIBGCC_HAVE_LIBATOMIC=