From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 414313858435; Tue, 23 Jan 2024 09:46:30 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 414313858435
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1706003192;
	bh=PS+VJdnAqkditMUZXvsrWSXF6pchJ6GSG+x0/q33NcQ=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=OqusRrsgBgneEmi07/6xDiHlwgtdrb57rPdQEyW7k3tGvRPUG7BkNb/C10Uj9A+cR
	 INvv3pZdlEuoQUAC0R4RVHYmdT2kjP4iCN6pYYtkWQJjaK+vJ3LxkJM0ZEcKdNxPLv
	 sd7CLEpX7b0Lj4hIsWrj2U3WWuMU39+3sHY73T/M=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/112820] vtable not emitted correctly from module when
 compiling with -g
Date: Tue, 23 Jan 2024 09:46:29 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: 13.2.0
X-Bugzilla-Keywords: documentation, internal-improvement, link-failure
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-112820-4-v6ioACDTOc@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-112820-4@http.gcc.gnu.org/bugzilla/>
References: <bug-112820-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D112820

--- Comment #3 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Nathaniel Shead <nshead@gcc.gnu.org>:

https://gcc.gnu.org/g:affef534b0335592336c82918f15242576e2ab8f

commit r14-8350-gaffef534b0335592336c82918f15242576e2ab8f
Author: Nathaniel Shead <nathanieloshead@gmail.com>
Date:   Wed Jan 17 16:50:39 2024 +1100

    c++: Fix handling of extern templates in modules [PR112820]

    Currently, extern templates are detected by looking for the
    DECL_EXTERNAL flag on a TYPE_DECL. However, this is incorrect:
    TYPE_DECLs don't actually set this flag, and it happens to work by
    coincidence due to TYPE_DECL_SUPPRESS_DEBUG happening to use the same
    underlying bit. This however causes issues with other TYPE_DECLs that
    also happen to have suppressed debug information.

    Instead, this patch reworks the logic so CLASSTYPE_INTERFACE_ONLY is
    always emitted into the module BMI and can then be used to check for an
    extern template correctly.

    Otherwise, for other declarations we always want to redetermine this:
    even for declarations from the GMF, we may change our mind on whether to
    import or export depending on decisions made later in the TU after
    importing so we shouldn't decide this now, or necessarily reuse what the
    module we'd imported had decided.

    Some of this may need to change in the future to account for
    https://github.com/itanium-cxx-abi/cxx-abi/issues/170.

            PR c++/112820
            PR c++/102607

    gcc/cp/ChangeLog:

            * module.cc (trees_out::lang_type_bools): Write interface_only
            and interface_unknown.
            (trees_in::lang_type_bools): Read the above flags.
            (trees_in::decl_value): Reset CLASSTYPE_INTERFACE_* except for
            extern templates.
            (trees_in::read_class_def): Remove buggy extern template
            handling.

    gcc/testsuite/ChangeLog:

            * g++.dg/modules/debug-2_a.C: New test.
            * g++.dg/modules/debug-2_b.C: New test.
            * g++.dg/modules/debug-2_c.C: New test.
            * g++.dg/modules/debug-3_a.C: New test.
            * g++.dg/modules/debug-3_b.C: New test.

    Signed-off-by: Nathaniel Shead <nathanieloshead@gmail.com>=