From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 922573858D38; Mon, 11 Dec 2023 18:08:42 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 922573858D38
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1702318122;
	bh=NQ2L3Jt0E/K72r+TQjQgVZSIkX9TIsvSDO80bsdufXc=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=sjK8E8kAPa8N+ZiXcxFSVkKjhXsDAOjKmqUbqWmvHyYnyG20yG7C9y9Te7336/xmE
	 jK8/bjoPNt/KJ24P2SUoWupNyuKiWwKUz28dv7d1WteeL72BaTlGUTq3G+ZMN+yxiD
	 6cjFNiL2hG+/t227R5+xfP8k6sUKhY+Jr2HHR718=
From: "bergner at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/112822] [14 regression] ICE: invalid RHS for gimple
 memory store after r14-5831-gaae723d360ca26
Date: Mon, 11 Dec 2023 18:08:42 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: middle-end
X-Bugzilla-Version: 14.0
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: bergner at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P1
X-Bugzilla-Assigned-To: jamborm at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 14.0
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-112822-4-8maGlopAzr@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-112822-4@http.gcc.gnu.org/bugzilla/>
References: <bug-112822-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D112822

--- Comment #7 from Peter Bergner <bergner at gcc dot gnu.org> ---
(In reply to Martin Jambor from comment #5)
> diff --git a/gcc/tree-sra.cc b/gcc/tree-sra.cc
> index 3bd0c7a9af0..99a1b0a6d17 100644
> --- a/gcc/tree-sra.cc
> +++ b/gcc/tree-sra.cc
> @@ -4219,11 +4219,15 @@ load_assign_lhs_subreplacements (struct access *l=
acc,
>           if (racc && racc->grp_to_be_replaced)
>             {=20
>               rhs =3D get_access_replacement (racc);
> +             bool vce =3D false;
>               if (!useless_type_conversion_p (lacc->type, racc->type))
> -               rhs =3D fold_build1_loc (sad->loc, VIEW_CONVERT_EXPR,
> -                                      lacc->type, rhs);
> +               {
> +                 rhs =3D fold_build1_loc (sad->loc, VIEW_CONVERT_EXPR,
> +                                        lacc->type, rhs);
> +                 vce =3D true;
> +               }
>=20
> -             if (racc->grp_partial_lhs && lacc->grp_partial_lhs)
> +             if (lacc->grp_partial_lhs && (vce || racc->grp_partial_lhs))
>                 rhs =3D force_gimple_operand_gsi (&sad->old_gsi, rhs, tru=
e,
>                                                 NULL_TREE, true,
> GSI_SAME_STMT);
>             }

This fixes the ICE on the large original test case and the smaller test cas=
es.=20
I'll bootstrap and regtest it and report back on the results.=