From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 85D403858403; Tue, 5 Dec 2023 08:48:24 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 85D403858403 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1701766104; bh=237S1Kh0syorZGpaiUApJxPWxioGV+tMdJZPXKhnW8c=; h=From:To:Subject:Date:In-Reply-To:References:From; b=nuwgfVoOhgW4J3GJKHzW1zysqS98Otukt2sLyTvLjI+OZddV0IvpBQbFgIIQmthBL BCQ9Iih8wzZX50VplsBJxysRnClDZyfghqC6tW9QFEjzGUQbTG/DLepkmD5Y7xmzTl zb4F0JOUrWgpxz+EgYi6ITnxqln6Bh8vP+didvpQ= From: "cvs-commit at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/112843] during GIMPLE pass: bitintlower ICE: SIGSEGV in ranger_cache::range_of_expr (gimple-range-cache.cc:1204) with _BitInt() at -O1 Date: Tue, 05 Dec 2023 08:48:23 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: tree-optimization X-Bugzilla-Version: 14.0 X-Bugzilla-Keywords: ice-on-valid-code X-Bugzilla-Severity: normal X-Bugzilla-Who: cvs-commit at gcc dot gnu.org X-Bugzilla-Status: ASSIGNED X-Bugzilla-Resolution: X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: jakub at gcc dot gnu.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 List-Id: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D112843 --- Comment #10 from GCC Commits --- The master branch has been updated by Jakub Jelinek : https://gcc.gnu.org/g:1a84af19cd18730477dbceaebc45466c3fd77b60 commit r14-6138-g1a84af19cd18730477dbceaebc45466c3fd77b60 Author: Jakub Jelinek Date: Tue Dec 5 09:45:40 2023 +0100 lower-bitint: Make temporarily wrong IL less wrong [PR112843] As discussed in the PR, for the middle (on x86-64 65..128 bit) _BitInt types like _1 =3D x_4(D) * 5; where _1 and x_4(D) have _BitInt(128) type and x is PARM_DECL, the biti= nt lowering pass wants to replace this with _13 =3D (int128_t) x_4(D); _12 =3D _13 * 5; _1 =3D (_BitInt(128)) _12; where _13 and _12 have int128_t type and the ranger ICEs when the IL is temporarily invalid: during GIMPLE pass: bitintlower pr112843.c: In function =C3=A2foo=C3=A2: pr112843.c:7:1: internal compiler error: Segmentation fault 7 | foo (_BitInt (128) x, _BitInt (256) y) | ^~~ 0x152943f crash_signal ../../gcc/toplev.cc:316 0x25c21c8 ranger_cache::range_of_expr(vrange&, tree_node*, gimple*) ../../gcc/gimple-range-cache.cc:1204 0x25cdcf9 fold_using_range::range_of_range_op(vrange&, gimple_range_op_handler&, fur_source&) ../../gcc/gimple-range-fold.cc:671 0x25cf9a0 fold_using_range::fold_stmt(vrange&, gimple*, fur_source&, tree_node*) ../../gcc/gimple-range-fold.cc:602 0x25b5520 gimple_ranger::update_stmt(gimple*) ../../gcc/gimple-range.cc:564 0x16f1234 update_stmt_operands(function*, gimple*) ../../gcc/tree-ssa-operands.cc:1150 0x117a5b6 update_stmt_if_modified(gimple*) ../../gcc/gimple-ssa.h:187 0x117a5b6 update_stmt_if_modified(gimple*) ../../gcc/gimple-ssa.h:184 0x117a5b6 update_modified_stmt ../../gcc/gimple-iterator.cc:44 0x117a5b6 gsi_insert_after(gimple_stmt_iterator*, gimple*, gsi_iterator_update) ../../gcc/gimple-iterator.cc:544 0x25abc2f gimple_lower_bitint ../../gcc/gimple-lower-bitint.cc:6348 What the code does right now is, it first creates a new SSA_NAME (_12 above), adds the _1 =3D (_BitInt(128)) _12; stmt after it (where it crashes, because _12 has no SSA_NAME_DEF_STMT y= et), then sets lhs of the previous stmt to _12 (this is also temporarily incorrect, there are incompatible types involved in the stmt), later on changes also operands and finally update_stmt it. The following patch instead changes the lhs of the stmt before adding t= he cast after it. The question is if this is less or more wrong temporari= ly (but the ICE is gone). In addition to that the patch moves the operand adjustments before the lhs adjustment. The reason I tweaked the lhs first is that it then just uses gimple_op = and iterates over all ops, if that is done before lhs it would need to spec= ial case which op to skip because it is lhs (I'm using gimple_get_lhs for t= he lhs, but this isn't done for GIMPLE_CALL nor GIMPLE_PHI, so GIMPLE_ASSI= GN or say GIMPLE_GOTO etc. are the only options). 2023-12-05 Jakub Jelinek PR tree-optimization/112843 * gimple-lower-bitint.cc (gimple_lower_bitint): Change lhs of s= tmt to lhs2 before building and inserting lhs =3D (cast) lhs2; assignment. Adjust stmt operands before adjusting lhs. * gcc.dg/bitint-47.c: New test.=