public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/112845] [11/12 Regression] ICE: in extract_insn, at recog.cc:2804 with -Os -fcf-protection -c since r8-3504
Date: Sat, 16 Dec 2023 00:38:14 +0000 [thread overview]
Message-ID: <bug-112845-4-E7Bh6xCL4L@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-112845-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112845
--- Comment #7 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:
https://gcc.gnu.org/g:87d013f7c877f944adbbaa4e94244baf990cb9f2
commit r12-10054-g87d013f7c877f944adbbaa4e94244baf990cb9f2
Author: Jakub Jelinek <jakub@redhat.com>
Date: Tue Dec 5 13:17:57 2023 +0100
i386: Fix -fcf-protection -Os ICE due to movabsq peephole2 [PR112845]
The following testcase ICEs in the movabsq $(i32 << shift), r64 peephole2
I've added a while back to use smaller code than movabsq if possible.
If i32 is 0xfa1e0ff3 and shift is not divisible by 8, then it creates
an invalid insn (as 0xfa1e0ff3 CONST_INT is not allowed as
x86_64_immediate_operand nor x86_64_zext_immediate_operand), the peephole2
even triggers on it again and again (this time with shift 0) until it gives
up.
The following patch fixes that. As ix86_endbr_immediate_operand needs a
CONST_INT and it is hopefully rare, I chose to use FAIL rather than
handling
it in the condition (where I'd probably need to call ctz_hwi again etc.).
2023-12-05 Jakub Jelinek <jakub@redhat.com>
PR target/112845
* config/i386/i386.md (movabsq $(i32 << shift), r64 peephole2):
FAIL
if the new immediate is ix86_endbr_immediate_operand.
(cherry picked from commit e0786ca9a18c50ad08c40936b228e325193664b8)
next prev parent reply other threads:[~2023-12-16 0:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-04 14:04 [Bug target/112845] New: ICE: in extract_insn, at recog.cc:2804 with -Os -fcf-protection -c iamanonymous.cs at gmail dot com
2023-12-04 15:35 ` [Bug target/112845] [11/12/13/14 Regression] ICE: in extract_insn, at recog.cc:2804 with -Os -fcf-protection -c since r8-3504 jakub at gcc dot gnu.org
2023-12-04 15:38 ` jakub at gcc dot gnu.org
2023-12-04 15:38 ` jakub at gcc dot gnu.org
2023-12-05 12:18 ` cvs-commit at gcc dot gnu.org
2023-12-05 12:19 ` [Bug target/112845] [11/12/13 " jakub at gcc dot gnu.org
2023-12-05 16:33 ` cvs-commit at gcc dot gnu.org
2023-12-05 17:02 ` [Bug target/112845] [11/12 " jakub at gcc dot gnu.org
2023-12-16 0:38 ` cvs-commit at gcc dot gnu.org [this message]
2023-12-17 13:55 ` cvs-commit at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-112845-4-E7Bh6xCL4L@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).